New issue
Advanced search Search tips

Issue 710371 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue 708475



Sign in to add a comment

Consolidate WebrtcAudioPrivateFunction::GetRenderProcessHostFromRequest and WebrtcLoggingPrivateFunction::RphFromRequest

Project Member Reported by hlundin@chromium.org, Apr 11 2017

Issue description

There are two methods in two different private API extensions that are more or less identical. These are WebrtcLoggingPrivateFunction::RphFromRequest from which WebrtcAudioPrivateFunction::GetRenderProcessHostFromRequest was stolen (and slightly modified according to reviewer comments).

These two should be consolidated.

Also, the reviewer commented that "Using strings to compare origins is scary for lots of reasons. Can we instead use the url libraries?" This was related to 
if (expected_origin.spec() != security_origin) {...}

 
Blockedon: 708475
Cc: solenberg@chromium.org

Sign in to add a comment