Issue metadata
Sign in to add a comment
|
Permission update strings are confusing |
||||||||||||||||||||||||
Issue description1. Ensure Chrome has microphone and camera access 2. Go to https://permission.site and request microphone+camera 3. Grant access 4. Now go to Android settings and remove microphone and camera access 5. Go back to https://permission.site and request microphone+camera You should get a prompt saying "Chrome needs permissions access to share them with this site." If you say "update permissions" you then get multiple permission requests from Android, one after the other. Note, if only one permission is requested the string is customized to that permission. The problem is when multiple permissions all need to be updated at once. We should find a better string, for example: "Chrome needs access to multiple permissions to share them with this site." (this bug was split off from 709206)
,
Apr 13 2017
Comments from other bug: **** srahim: benwells@, both strings are confusing because of the use of "it" and "them". Ideally, the location one would say something along the lines of: 'Chrome needs location access to share your location with this site' 'For this site to work properly, share your location with Chrome and the site' Strings don't block the associated eng fixes that have been made, but this is an example of a string that will probably trip up Loc. It would be nice to clarify the location string as well as the permissions one. **** battre: FWIW, I think that the second string suggests an error condition and does not reflect that it's the user's choice whether to grant permission or not.
,
Apr 13 2017
My 2c - the first suggestion makes it more clear that the problem is with Chrome not having permission at the Android level.
,
Apr 25 2017
Ben and others, I put together a doc w/recommendations, PTAL: https://docs.google.com/document/d/1_8cKddMXQD9waV2qFz4N5Gu2a0wlOFIqV9KaCdaW87U/edit
,
Apr 25 2017
,
May 8 2017
Looking at the code, only these combinations should be valid: - geolocation - camera - mic - camera+mic - storage Given that, I'll look at removing the generic multi-permissions string and CHECKing instead.
,
May 8 2017
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/036e0cf6141f26632ddfe2aec1867418d3acdf9c commit 036e0cf6141f26632ddfe2aec1867418d3acdf9c Author: benwells <benwells@chromium.org> Date: Fri May 19 20:34:17 2017 Remove usage of the generic multiple permissions update string. The only combination of multiple permissions to update that is ever used is microphone and camera. This change introduces a custom string just for that case and other usages are treated as an error (and CHECKed). BUG= 710362 Review-Url: https://codereview.chromium.org/2872853004 Cr-Commit-Position: refs/heads/master@{#473297} [modify] https://crrev.com/036e0cf6141f26632ddfe2aec1867418d3acdf9c/chrome/android/java/src/org/chromium/chrome/browser/permissions/AndroidPermissionRequester.java [modify] https://crrev.com/036e0cf6141f26632ddfe2aec1867418d3acdf9c/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/036e0cf6141f26632ddfe2aec1867418d3acdf9c/chrome/app/chromium_strings.grd [modify] https://crrev.com/036e0cf6141f26632ddfe2aec1867418d3acdf9c/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/036e0cf6141f26632ddfe2aec1867418d3acdf9c/chrome/browser/permissions/permission_update_infobar_delegate_android.cc [modify] https://crrev.com/036e0cf6141f26632ddfe2aec1867418d3acdf9c/chrome/browser/permissions/permission_update_infobar_delegate_android.h
,
May 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36ecf1abe91cd116d144aeb82b821bd201587916 commit 36ecf1abe91cd116d144aeb82b821bd201587916 Author: benwells <benwells@chromium.org> Date: Sun May 21 23:03:44 2017 Change strings for update permissions infobar. The strings were brief but confusing. BUG= 710362 Review-Url: https://codereview.chromium.org/2869763002 Cr-Commit-Position: refs/heads/master@{#473488} [modify] https://crrev.com/36ecf1abe91cd116d144aeb82b821bd201587916/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/36ecf1abe91cd116d144aeb82b821bd201587916/chrome/app/chromium_strings.grd [modify] https://crrev.com/36ecf1abe91cd116d144aeb82b821bd201587916/chrome/app/generated_resources.grd [modify] https://crrev.com/36ecf1abe91cd116d144aeb82b821bd201587916/chrome/app/google_chrome_strings.grd
,
May 21 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by benwells@chromium.org
, Apr 13 2017Summary: Permission update strings are confusing (was: Permission update string is confusing when multiple permissions requested)