New issue
Advanced search Search tips

Issue 710357 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocking:
issue 707630



Sign in to add a comment

bluetooth: Separate DeviceChanged into more specific functions

Project Member Reported by ortuno@chromium.org, Apr 11 2017

Issue description

BluetoothAdapterObserver::DeviceChanged is a catch-all event that gets called for all events that pertain to a device. This leads to clients having to keep the state of a device themselves to understand what changed when DeviceChanged is called. Some clients just assume that the DeviceChanged is called whenever an advertisement is received causing to incorrectly dispatch events.

// Called when the result of one of the following methods of the device
// |device| changes:
//  * GetAddress()               // We already have DeviceAddressChanged.
//  * GetAppearance()            // Should be part of "AdvertisementReceived"
//  * GetBluetoothClass()        // Should be part of "ClassicDeviceFound"
//  * GetInquiryRSSI()           // Should be part of "AdvertisementReceived"
//  * GetInquiryTxPower()        // Ditto.
//  * GetUUIDs()                 // Ditto.
//  * GetServiceData()           // Ditto.
//  * GetServiceDataUUIDs()      // Ditto.
//  * GetServiceDataForUUID()    // Ditto.
//  * GetManufacturerData()      // Ditto.
//  * GetManufacturerDataIDs()   // Ditto.
//  * GetManufacturerDataForID() // Ditto.
//  * GetAdvertisingDataFlags()  // Ditto.
//  * IsConnectable()            // Ditto.
//  * IsConnected()              // Should be part of DeviceConnectionStateChanged
//  * IsConnecting()             // Ditto.
//  * IsGattConnected()          // Ditto.
//  * IsPaired()                 // We already have DevicePairedChanged

 
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment