bluetooth: Remove ServiceAdded/Removed, CharacteristicAdded/Removed, DescriptorAdded/Removed |
|||
Issue descriptionThese observer method were added because DBus' ObjectManager has them but they are barely used by anyone. They are just adding complexity to the other implementations. We should remove them. New code should use Observer::GattServicesDiscovered and then call GetGattService(s)() GetCharacteristic(s)() GetDescriptor(s)() Note that a remote device that modifies GATT attributes is not tested or expected to work with this code at this time.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cdca91be32c10d85ea71cdf775da9bd28837cc6 commit 0cdca91be32c10d85ea71cdf775da9bd28837cc6 Author: Vincent Scheib <scheib@chromium.org> Date: Fri Nov 10 00:41:25 2017 bluetooth: Deprecate GATT Added/Removed events & GattDiscoveryCompleteForService The series of Observer methods for Service, Characteristic, & Descriptor Added/Removed events are marked deprecated. They are rarely used and add API & implementation complexity. They are not reliable for cross platform use, and devices that modify their attribute table have not been tested or supported. Also, GattDiscoveryCompleteForService is marked deprecated as it is not functional on all platforms. Use GattServicesDiscovered. Bug: 710352, 782494 Change-Id: I96aef12d961cf1033c88aa4933bd3882601da1fa Reviewed-on: https://chromium-review.googlesource.com/758057 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Conley Owens <cco3@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#515374} [modify] https://crrev.com/0cdca91be32c10d85ea71cdf775da9bd28837cc6/device/bluetooth/bluetooth_adapter.h
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bdca957730ba327879d81022f5e41926f5b90ba commit 9bdca957730ba327879d81022f5e41926f5b90ba Author: Conley Owens <cco3@chromium.org> Date: Fri Nov 17 19:04:21 2017 bluetooth: Mark GattServiceChanged as deprecated Similar adapter observer methods have already been marked deprecated. GattServiceChanged is not all too different since it is fired when essentially the device changes shape (attributes are added/removed). This change also removes a platform-specific use of gatt_service_changed_count() and gatt_characteristic_added_count(). BUG=710352 Change-Id: Iffe8118083ec10ba762eacb18886bca3acda2d58 Reviewed-on: https://chromium-review.googlesource.com/776354 Commit-Queue: Conley Owens <cco3@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Reviewed-by: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#517498} [modify] https://crrev.com/9bdca957730ba327879d81022f5e41926f5b90ba/device/bluetooth/bluetooth_adapter.h [modify] https://crrev.com/9bdca957730ba327879d81022f5e41926f5b90ba/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc
,
Nov 19
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 21
|
|||
►
Sign in to add a comment |
|||
Comment 1 by scheib@chromium.org
, Nov 8 2017