New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 710349 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] 'Add pattern' link is not clickable under 'Request blocking' section.

Reported by dchau...@etouch.net, Apr 11 2017 
Chrome Version: 59.0.3068.1 (Official Build)2f0cdddf2601f4c9862b35013630d230da469892-refs/branch-heads/3068@{#1} 32/64-bit.
OS: Windows(7,8,10).

What steps will reproduce the problem?
(1) Launch chrome, open DevTools and go to 'Request blocking' section in Console drawer.
(2) Now, Click on 'Add pattern' link in 'Request blocking' section and observe.

'Add pattern' link is not clickable.
'Add pattern' link should be clickable.

This is a regression issue, broken in M-59 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Apr 11 2017 

Below is manual regression range.

Good build: 59.0.3067.0
Bad build: 59.0.3068.1

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
893 KB View Download
Expected behavior.mp4
491 KB View Download

Comment 2 by rbasuvula@chromium.org, Apr 11 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable OS-Linux OS-Mac
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3067.0 (Revision:463157).
Bad build:59.0.3068.1 (Revision:463474).

You are probably looking for a change made after 463407 (known good), but no later than 463408 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/2abcf0413069159c73bceba72f0b6f124021bca5..75f0c42bc1fa4789792e165292bef3334b97151e

From the CL above, assigning the issue to the concern owner

@dgozman: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2814563004
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3068.1
Adding Release Block-Stable for this issue.Please remove if not the case.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/923a36a0089cff4f9e9ce2fa51809ab75ff3a749

commit 923a36a0089cff4f9e9ce2fa51809ab75ff3a749
Author: dgozman <dgozman@chromium.org>
Date: Tue Apr 11 20:59:50 2017

[DevTools] Do not disable blocked URLs list when it's empty

So that 'Add pattern' link continues to work.

BUG= 710349 
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2807293004
Cr-Commit-Position: refs/heads/master@{#463765}

[modify] https://crrev.com/923a36a0089cff4f9e9ce2fa51809ab75ff3a749/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

Comment 4 by dgozman@chromium.org, Apr 11 2017

Status: Fixed (was: Assigned)

Comment 5 by sureshkumari@chromium.org, Apr 18 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3071.9
Tested the issue on Windows-7,Mac-10.12.4 and Linux Ubuntu-14.04 using chrome version# 59.0.3071.9.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
710349.mp4
478 KB View Download
►

Sign in to add a comment