Blink uses kFooStyle now, to avoid collisions with macros. To avoid this detail from leaking into Java, we should fix the script to just handle this case automatically.
CL for the update here: https://codereview.chromium.org/2815103004/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23b8f65ce75fc2ff04a28cb5a940861c134e0797 commit 23b8f65ce75fc2ff04a28cb5a940861c134e0797 Author: estevenson <estevenson@chromium.org> Date: Fri Apr 14 02:40:13 2017 Android: convert kEnumName to ENUM_NAME in java_cpp_enum.py. Since the Blink rename, enum entry names now use the kCamelCase naming convention instead of SHOUTY_CASE. This doesn't match well with Java naming conventions and Java constants created by java_cpp_enum.py look out of place with the rest of the Java codebase. This CL modifies java_cpp_enum.py so that C++ enum naming conventions don't leak into the Java side, specifically translating kCamelCase and CamelCase enum entries to SHOUTY_CASE. BUG= 710335 Review-Url: https://codereview.chromium.org/2815103004 Cr-Commit-Position: refs/heads/master@{#464661} [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/build/android/gyp/java_cpp_enum.py [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/build/android/gyp/java_cpp_enum_tests.py [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/media/base/android/java/src/org/chromium/media/CodecProfileLevelList.java [modify] https://crrev.com/23b8f65ce75fc2ff04a28cb5a940861c134e0797/media/base/android/java/src/org/chromium/media/MediaCodecUtil.java
Comment 1 by estevenson@chromium.org
, Apr 11 2017Owner: estevenson@chromium.org
Status: Assigned (was: Untriaged)