Bug: vs. TBR= in chromium presubmit |
||||||
Issue descriptionpresubmit_canned_checks.py and presubmit_support.py look for TBR= (because of Change.TAG_LINE_RE in presubmit_support.py), but that's inconsistent with the new Bug: style, made default by issue 681184 . So now I have a change like https://chromium-review.googlesource.com/c/474585/ that has Bug:, Change-Id: and TBR=, which looks daft.
,
Apr 12 2017
Yep, need to fix this. Working on a change to fix this, but the PRESUBMIT API is also daft and makes doing this at all reasonably way harder than it should be. P.S. please don't file these issues directly against me. Use the Infra>Codereview>Gerrit component or Proj-Gerrit-Migration label and it'll hit our triage queue.
,
Apr 12 2017
,
Apr 12 2017
> P.S. please don't file these issues directly against me Yep sorry, I just git blame'd the BUG= to Bug: change and found you :) Thanks for triaging!
,
Apr 21 2017
,
May 15 2017
https://chromium-review.googlesource.com/c/506450 and https://chromium-review.googlesource.com/c/506551/
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6 commit fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6 Author: Aaron Gable <agable@chromium.org> Date: Thu May 18 19:02:54 2017 Refactor PRESUBMIT support for tags We want PRESUBMIT to be able to equally support BUG= tags (old style) and Git-Footer: footers (new style). This change refactors the way that the presubmit api gives access to those properties so that it is easier to add support for equivalent footers. It also limits the scope of tags/footers that it exposes, as code search shows no PRESUBMIT files that take advantage of any of the more esoteric ones. Bug: 710327 , 710803 Change-Id: I86f1d6cb2e1f0aff9653ef3fb455e0a6f47acf5d Reviewed-on: https://chromium-review.googlesource.com/506450 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6/presubmit_canned_checks.py [modify] https://crrev.com/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6/presubmit_support.py [modify] https://crrev.com/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6/tests/presubmit_unittest.py
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/12ef501b02a9ff66323ba2da0432dc6717d5bc89 commit 12ef501b02a9ff66323ba2da0432dc6717d5bc89 Author: Aaron Gable <agable@chromium.org> Date: Fri May 19 16:56:29 2017 Parse Bug, R, and Tbr git-footers in PRESUBMIT This gives PRESUBMIT equal support for all the gerrit-style footers that we're migrating to. R=iannucci@chromium.org, tandrii@chromium.org Bug: 710327 , 710803 Change-Id: I64b8f39ef923d90ebda7dd191b83d1a7cc87c776 Reviewed-on: https://chromium-review.googlesource.com/506551 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/12ef501b02a9ff66323ba2da0432dc6717d5bc89/presubmit_support.py [modify] https://crrev.com/12ef501b02a9ff66323ba2da0432dc6717d5bc89/tests/presubmit_unittest.py
,
May 19 2017
PRESUBMIT is now willing to look for both BUG= and Bug:, it should no longer force you to have mixed types of footers in your commit message. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by aga...@chromium.org
, Apr 12 2017