New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710298 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Toast notifications disappear while focused

Project Member Reported by edcourtney@chromium.org, Apr 11 2017

Issue description

Notifications being displayed as toasts seem to disappear even when they have been focused.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c556f5a3a662c0b79ae7961f8bdbfaf2cc4236fb

commit c556f5a3a662c0b79ae7961f8bdbfaf2cc4236fb
Author: edcourtney <edcourtney@chromium.org>
Date: Wed Apr 12 07:40:30 2017

Stop notification updates from unpausing toast timers.

Notification toast timers are paused when the notification gains
focus. If a notification is updated while it is paused, then previously,
its timer would be unpaused. So, it would disappear while being focused.

BUG= 710298 

Review-Url: https://codereview.chromium.org/2810723004
Cr-Commit-Position: refs/heads/master@{#463943}

[modify] https://crrev.com/c556f5a3a662c0b79ae7961f8bdbfaf2cc4236fb/ui/message_center/popup_timer.h
[modify] https://crrev.com/c556f5a3a662c0b79ae7961f8bdbfaf2cc4236fb/ui/message_center/popup_timers_controller.cc

Labels: Merge-Request-58 M-58
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 12 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please add applicable OSs.  Thanks!
Labels: OS-Chrome
Thanks~ I'll remember next time!
Labels: -Hotlist-Merge-Review -Merge-Review-58 Merge-Approved-58
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 14 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f41f7a2f609c86c39fce1c92b1e4f0438e447ff

commit 0f41f7a2f609c86c39fce1c92b1e4f0438e447ff
Author: yhanada <yhanada@chromium.org>
Date: Fri Apr 14 04:37:21 2017

Stop notification updates from unpausing toast timers.

Notification toast timers are paused when the notification gains
focus. If a notification is updated while it is paused, then previously,
its timer would be unpaused. So, it would disappear while being focused.

BUG= 710298 

Review-Url: https://codereview.chromium.org/2810723004
Cr-Commit-Position: refs/heads/master@{#463943}
(cherry picked from commit c556f5a3a662c0b79ae7961f8bdbfaf2cc4236fb)

Review-Url: https://codereview.chromium.org/2815093006 .
Cr-Commit-Position: refs/branch-heads/3029@{#708}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/0f41f7a2f609c86c39fce1c92b1e4f0438e447ff/ui/message_center/popup_timer.h
[modify] https://crrev.com/0f41f7a2f609c86c39fce1c92b1e4f0438e447ff/ui/message_center/popup_timers_controller.cc

I merged the change to M-58 on behalf of Eliot.
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
9334.69.0, 58.0.3029.112

Sign in to add a comment