New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710295 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit 15 days ago
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update NotShared<> to use Member instead of UntracedMember

Project Member Reported by binji@chromium.org, Apr 11 2017

Issue description

It's best if STACK_ALLOCATED classes use Member. Currently NotShared<> uses UntracedMember because it is constructed on a non-oilpan thread in OfflineAudioDestinationNode. That thread calls getChannelData on an AudioBuffer, which returns a NotShared<DOMFloat32Array>.

It is OK in this case, because the AudioBuffer is being kept alive via a CrossThreadPersistent<> handle, but it would be better if NotShared<> was not constructed in that case, so we could switch it to using Member instead of UntracedMember.

See discussion here: https://codereview.chromium.org/2707243006#msg66
 

Sign in to add a comment