New issue
Advanced search Search tips

Issue 710291 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extraneous focus animation on checkbox in sync confirmation dialogue

Project Member Reported by ew...@chromium.org, Apr 11 2017

Issue description

See  Issue 709113  for background (and specifically comments #10 & #14). When the sync confirmation dialogue finishes appearing, there's an extraneous focus animation on the checkbox momentarily.

Attaching a gif of the issue.
 
checkbox-focus.gif
214 KB View Download

Comment 1 by dbeam@chromium.org, Apr 11 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee6794b5b8e7c06965106741ada8d94beedf98cc

commit ee6794b5b8e7c06965106741ada8d94beedf98cc
Author: dbeam <dbeam@chromium.org>
Date: Tue Apr 11 15:56:02 2017

Sync confirmation: hide extraneous checkbox ripple on early focus

Only happens on Mac due to platform-specific focus logic I don't really
want to dive into that much.

R=tommycli@chromium.org
BUG= 710291 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2808293003
Cr-Commit-Position: refs/heads/master@{#463643}

[modify] https://crrev.com/ee6794b5b8e7c06965106741ada8d94beedf98cc/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html
[modify] https://crrev.com/ee6794b5b8e7c06965106741ada8d94beedf98cc/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js

Comment 3 by dbeam@chromium.org, Apr 11 2017

Status: Fixed (was: Started)

Sign in to add a comment