ecryptfs->ext4crypto: Icon image for the notification of "user skip then migrate" flow. |
||||||||||||
Issue descriptionI'm tentatively landing the notification with Play icon (used for the ARC opt-in notification): https://codereview.chromium.org/2813633002/ mitsuji@, could you give me the intended icon image file (1x and 2x) as defined in the mock?
,
Apr 13 2017
Here are the assets for the notification. Please let me know if you have any questions. https://drive.google.com/open?id=0B_2Uyb2Rhx2OcV9zdzk5dGlCMUk
,
Apr 13 2017
thanks!
,
Apr 17 2017
Several questions are raised from the reviewer to the designer? Elizabeth, could you mind taking a look at https://codereview.chromium.org/2820433002/ ?
,
Apr 17 2017
I have replied to the thread. Thanks!
,
Apr 17 2017
Additional questions are posted on the review thread. Could you mind revisiting? Thanks for your help.
,
Apr 19 2017
(friendly ping) Hi Elizabeth, could you take yet another look on the review thread? New questions are added
,
Apr 19 2017
Sorry that I do not get notified when you post questions at the code review thread. Please post questions here if possible.
,
Apr 20 2017
Screenshot after reflecting the offline discussion: https://drive.google.com/file/d/0B5GWhwdfG_jTM3hBQlR2UldTWTg/view?usp=sharing
,
Apr 20 2017
I've stamped the CL but I would still like to understand when we prefer full-bleed notifications vs. "normal" icons.
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e1744c8c2203042c4f459b26eabf19eb0c99641 commit 2e1744c8c2203042c4f459b26eabf19eb0c99641 Author: kinaba <kinaba@chromium.org> Date: Fri Apr 21 03:26:50 2017 arc: Add icon resource for the notification in migration-skipped session. BUG= 710285 TEST=manual (the intended image was shown.) Review-Url: https://codereview.chromium.org/2820433002 Cr-Commit-Position: refs/heads/master@{#466246} [modify] https://crrev.com/2e1744c8c2203042c4f459b26eabf19eb0c99641/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/2e1744c8c2203042c4f459b26eabf19eb0c99641/chrome/app/vector_icons/arc_migrate_encryption_notification.icon [modify] https://crrev.com/2e1744c8c2203042c4f459b26eabf19eb0c99641/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
,
Apr 21 2017
Passing the ownership to elizabethchiu@ on the question #10
,
Apr 21 2017
estade@ Do you mean the icon in full bleed or trimmed size? Or do you mean visually? We use "normal"icons most of the time.
,
Apr 21 2017
,
Apr 22 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cc097225f8a42de3f7eae61126f41f069224dcc commit 7cc097225f8a42de3f7eae61126f41f069224dcc Author: Kazuhiro Inaba <kinaba@chromium.org> Date: Mon Apr 24 00:40:42 2017 arc: Add icon resource for the notification in migration-skipped session. BUG= 710285 TEST=manual (the intended image was shown.) Review-Url: https://codereview.chromium.org/2820433002 Cr-Commit-Position: refs/heads/master@{#466246} (cherry picked from commit 2e1744c8c2203042c4f459b26eabf19eb0c99641) Review-Url: https://codereview.chromium.org/2835053002 . Cr-Commit-Position: refs/branch-heads/3071@{#149} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/7cc097225f8a42de3f7eae61126f41f069224dcc/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/7cc097225f8a42de3f7eae61126f41f069224dcc/chrome/app/vector_icons/arc_migrate_encryption_notification.icon [modify] https://crrev.com/7cc097225f8a42de3f7eae61126f41f069224dcc/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
,
Apr 24 2017
,
May 16 2017
kinaba@ Trying to verify this bug. Could you provide verification steps? I AU'd my Kevin device from M59 to TOT -> critical update available -> sign-in to user -> see migration UI -> click on Skip button I did not see the notification in c#9
,
May 17 2017
The icon has landed but the code path to enable the notification is not finished yet ( Bug 699850 ). This bug can be verified altogether when the blocker bug is fixed. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by mitsuji@chromium.org
, Apr 11 2017