Issue 710278 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	tkent@chromium.org
Closed:	Oct 2017
Cc:	dcheng@chromium.org
Components:	Blink>Internals
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Hotlist-GoodFirstBug

Blocking:
issue 675877

Some type-check/type-cast functions/macros have WebKit-style

Project Member Reported by tkent@chromium.org, Apr 11 2017

Issue description

Some type-check/type-cast functions start with "Is" or "To".
  e.g. IsHTMLElement(), ToHTMLElement()

However, some type-check/type-cast functions start with "is" or "to".
  e.g. isHTMLInputElement(), toHTMLInputElement().

Generated code defines the latter. See Source/core/build/scripts/make_element_type_helpers.py and Source/core/build/scripts/templates/ElementTypeHelpers.*.tmpl.

Comment 1 by tkent@chromium.org, Aug 31 2017

Labels: Hotlist-GoodFirstBug

Comment 2 by tkent@chromium.org, Aug 31 2017

Components: Blink>Internals
Status: Available (was: Untriaged)

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04bf87824243acee4aba356430b1e8f5b0ed693e

commit 04bf87824243acee4aba356430b1e8f5b0ed693e
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Sep 29 09:54:08 2017

Rename isFooElement() to IsFooElement().

According the current coding style guide, function names should start
with capital letters.

- Update ElementTypeHelpers.h.tmpl
- Replace exising calls for isFooElement() with IsFooElement()
- Remove some unnecessary ASSERT_TRUE(isFooElement()) followed by
  toFooElement(), which contains the SECURITY_DCHECK.

Bug:  710278 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4fa5a4fced83a1015816ecdeb0636fde9b832c21
Reviewed-on: https://chromium-review.googlesource.com/689875
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505339}
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/css/StyleEngine.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/css/StyleSheetCandidate.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/css/StyleSheetList.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/AXObjectCache.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/ElementShadowV0.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/ElementTest.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/FlatTreeTraversal.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/ShadowRootRareDataV0.h
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/TreeOrderedMap.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/V0InsertionPoint.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/VisitedLinkState.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/dom/events/EventDispatcher.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/EditorTest.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/RenderedPosition.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/TextFinder.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/PrerenderingTest.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebDocumentSubresourceFilterTest.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebFormControlElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebFormElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebFrameSerializer.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebInputElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebLabelElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebMetaElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebOptionElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebSearchableFormData.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebSelectElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/frame/SmartClip.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/frame/WebFrameSerializerImpl.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/fullscreen/Fullscreen.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/DocumentNameCollection.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLCollection.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLEmbedElementTest.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLHRElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLLIElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLOptionsCollection.h
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLTableCellElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLTablePartElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLTableRowsCollection.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/LabelsNodeList.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/ListItemOrdinal.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/RadioNodeList.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/WindowNameCollection.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/forms/OptionList.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/parser/HTMLElementStack.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/GeneratedChildren.h
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutButton.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutButton.h
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutCounter.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutImage.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutListBox.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/svg/LayoutSVGEllipse.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/page/ContextMenuClient.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/page/SpatialNavigation.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/page/TouchAdjustment.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/page/TouchDisambiguation.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/ImagePainter.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/ThemePainter.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/compositing/GraphicsLayerTreeBuilder.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGLinearGradientElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGPatternElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGRadialGradientElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGTSpanElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/04bf87824243acee4aba356430b1e8f5b0ed693e/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modif

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5d174734faa19a2f73f29e777bbd697f16c39ab

commit a5d174734faa19a2f73f29e777bbd697f16c39ab
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Oct 02 01:15:57 2017

Rename toFooElement() to ToFooElement()

and toFooElementOrDie() to ToFooElementOrDie().

According the current coding style guide, function names should start
with capital letters.

- Update ElementTypeHelpers.h.tmpl
- Replace exising calls for toFooElement*() with ToFooElement*()

Bug:  710278 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaf5b2f0856a8dee11259f5a2131ad299a486642c
Reviewed-on: https://chromium-review.googlesource.com/692214
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505528}
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/css/StyleElementTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/css/StyleEngine.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/css/StyleEngineTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/css/StyleSheetCandidate.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/css/StyleSheetList.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/DocumentTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/ElementShadowV0.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/FlatTreeTraversal.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/SlotAssignment.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/TreeOrderedMap.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/dom/VisitedLinkState.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/EditorTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/editing/testing/SelectionSample.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebDocument.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebDocumentSubresourceFilterTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebFormElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebFrameSerializer.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebInputElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebLabelElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebMetaElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebOptionElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebSearchableFormData.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebSelectElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/frame/DocumentLoadingRenderingTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/frame/VisualViewportTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/frame/WebFrameSerializerImpl.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/DocumentNameCollection.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLCollection.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLEmbedElementTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLMapElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLObjectElement.h
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLOptionsCollection.h
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLTablePartElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLTableRowsCollection.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLTableRowsCollection.h
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLTemplateElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/HTMLVideoElementPersistentTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/LabelsNodeList.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/LinkElementLoadingTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/RadioNodeList.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/TextControlElementTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/canvas/CanvasFontCacheTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/forms/PasswordInputTypeTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/forms/SliderThumbElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/imports/HTMLImportSheetsTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/media/AutoplayUmaHelperTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/media/MediaCustomControlsFullscreenDetectorTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/shadow/DetailsMarkerControl.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutFileUploadControl.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutFrame.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutHTMLCanvas.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutImage.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutListBox.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutProgress.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutTextControlMultiLine.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/LayoutVideo.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceRadialGradient.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/page/ContextMenuClient.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/page/SlotScopedTraversalTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/HTMLCanvasPaintInvalidator.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/HTMLCanvasPainter.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/ImagePainter.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/SVGImagePainter.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/ThemePainter.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/paint/compositing/GraphicsLayerTreeBuilder.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/scheduler/FrameThrottlingTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/svg/SVGImageLoader.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/svg/SVGLinearGradientElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/svg/SVGPathElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/svg/SVGPatternElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/svg/SVGRadialGradientElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXRelationCache.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp
[modify] https://crrev.com/a5d174734faa19a2f73f29e777bbd697f16c39ab/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp
[modify] http

Comment 5 by tkent@chromium.org, Oct 2 2017

Owner: tkent@chromium.org
Status: Fixed (was: Available)

►

Issue 710278 link

Issue metadata

Some type-check/type-cast functions/macros have WebKit-style

Issue description

Comment 1 by tkent@chromium.org, Aug 31 2017

Comment 1 Deleted

Comment 2 by tkent@chromium.org, Aug 31 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 29 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 2 2017

Comment 4 Deleted

Comment 5 by tkent@chromium.org, Oct 2 2017

Comment 5 Deleted

Sign in to add a comment