New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 710268 link

Starred by 1 user
Status: Fixed
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: May 2017
Cc:
█ bauerb@chromium.org
jkrcal@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Split out scheduling methods from the SuggestionsSource interface

Project Member Reported by bauerb@chromium.org, Apr 10 2017 
https://codereview.chromium.org/2806153005 pulls up a method from SnippetsBridge to SuggestionsSource that triggers a soft fetch via the scheduler. That method really should live in a dedicated interface that only contains scheduling-related methods.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba0a51b986fd26385a2e1009a8e2ec974bd43639

commit ba0a51b986fd26385a2e1009a8e2ec974bd43639
Author: dgn <dgn@chromium.org>
Date: Thu May 04 10:23:26 2017

[Suggestions] Move metrics and scheduling events out of SnippetsBridge

Extracts a SuggestionsEventReporter out of SnippetsBridge, that is
responsible for recording backend metrics and sending events used by
the fetch scheduler.

BUG= 710268 

Review-Url: https://codereview.chromium.org/2844033002
Cr-Commit-Position: refs/heads/master@{#469305}

[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
[rename] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java
[add] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporterBridge.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegate.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/java_sources.gni
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/browser/BUILD.gn
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/browser/android/ntp/ntp_snippets_bridge.h
[add] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc
[add] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/browser/android/ntp/suggestions_event_reporter_bridge.h
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/test/android/BUILD.gn
[rename] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java
[modify] https://crrev.com/ba0a51b986fd26385a2e1009a8e2ec974bd43639/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java

Comment 2 by dgn@chromium.org, May 22 2017

Cc: -dgn@chromium.org
Owner: dgn@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment