[Network] Incorrect font-weight for "Off" text |
|||||
Issue descriptionWhat is the expected result? Medium (600) What happens instead? Regular (500) See network mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Network_02.png%3Fz=width
,
Apr 25 2017
,
Apr 25 2017
To clarify: The font weight should be 500 when On (blue)? (I can't tell in the mock).
,
Apr 27 2017
LGTM Off: grey-900, 14px Roboto Medium (500) On: blue-500, 14px Roboto Medium (500)
,
Apr 27 2017
Did you mean (600) for off?: Off: grey-900, 14px Roboto Medium (600)
,
Apr 27 2017
I misspoke before, sorry. Both ON and OFF should be 500 which translates to Roboto-Medium in practice.
,
Apr 27 2017
So... that is what we had before, the bug is "change the weight from 500 to 600"... should we just close this as WontFix?
,
Apr 28 2017
Ah, I see, the current font-weight for "off" is "normal" which = 400. I will go ahead and make both 500 for both Network and Bluetooth ( issue 710259 ).
,
Apr 28 2017
Yeha you got it. Sorry for the confusion!
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d58d3252c4b935c9e3565d8afc394ec46c9644aa commit d58d3252c4b935c9e3565d8afc394ec46c9644aa Author: stevenjb <stevenjb@chromium.org> Date: Fri Apr 28 22:42:04 2017 MD Settings: Network and bluetooth polish This CL: * Fixes button spacing in the network details page. * Fixes the on/off toggle button font and color for network and bluetooth * Replaces incorrect primary/secondary button classes in dialogs with action/cancel-button * Corrects the blue color for action buttons as per UX * Converts the "add network" section to list-frame / list-item to correct borders and spacing. BUG= 710258 , 710259 , 710261 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2846763003 Cr-Commit-Position: refs/heads/master@{#468164} [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/device_page/display_overscan_dialog.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/internet_page/internet_page.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/internet_page/internet_subpage.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/settings_shared_css.html
,
Apr 28 2017
,
May 8 2017
Chrome OS 9532.0.0, 60.0.3092.0 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by steve...@chromium.org
, Apr 13 2017