[Network] button spacing on network details page is incorrect |
|||||
Issue descriptionWhat steps will reproduce the problem? (1) go to network > network details (2) Note that the DISCONNECT text is too far left from the 20px right padding (3) Note that there's 0px margins between DISCONNECT and FORGET What is the expected result? - DISCONNECT text (not ripple) should be 20px from the edge, to align with other controls. - there should be 8px margin between buttons
,
Apr 25 2017
,
Apr 25 2017
8px margin between what and what? If I put an 8px margin between the text then the highlight overlaps with the text of the nearby button. Putting 8px between the highlight and the next button seems to work best? Please clarify or provide a link to a spec, thanks!
,
Apr 27 2017
8px between highlight A and highlight B is what I meant. Thanks!
,
Apr 27 2017
That color is standard for all "primary" buttons in Settings. Surprisingly, that only includes: * Network connect / disconnect * 'OK' on the overscan dialog in the display subpage * 'Sign in to Chrome' (non chromeos) in the people section Should I go ahead and change it for all of these?
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d58d3252c4b935c9e3565d8afc394ec46c9644aa commit d58d3252c4b935c9e3565d8afc394ec46c9644aa Author: stevenjb <stevenjb@chromium.org> Date: Fri Apr 28 22:42:04 2017 MD Settings: Network and bluetooth polish This CL: * Fixes button spacing in the network details page. * Fixes the on/off toggle button font and color for network and bluetooth * Replaces incorrect primary/secondary button classes in dialogs with action/cancel-button * Corrects the blue color for action buttons as per UX * Converts the "add network" section to list-frame / list-item to correct borders and spacing. BUG= 710258 , 710259 , 710261 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2846763003 Cr-Commit-Position: refs/heads/master@{#468164} [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/device_page/display_overscan_dialog.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/internet_page/internet_page.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/internet_page/internet_subpage.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html [modify] https://crrev.com/d58d3252c4b935c9e3565d8afc394ec46c9644aa/chrome/browser/resources/settings/settings_shared_css.html
,
Apr 28 2017
,
May 8 2017
Chrome OS 9532.0.0, 60.0.3092.0
,
May 15 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by steve...@chromium.org
, Apr 13 2017