Issue metadata
Sign in to add a comment
|
Investigate showing LSD when tab isn't active |
||||||||||||||||||||||||
Issue descriptionThe LSD (location settings dialog) is shown when a site requests geolocation but location is disabled, if an experiment is enabled. This dialog should only show when the request is from the current tab. It doesn't appear to show in other cases but this needs to be investigated more.
,
Apr 13 2017
OK ... turns out this could be a problem for the DSE. Uploading a fix now, should have it out for review soon.
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8a8a089caa1188776c83e4344df494d6f30b969 commit b8a8a089caa1188776c83e4344df494d6f30b969 Author: benwells <benwells@chromium.org> Date: Wed Apr 19 22:53:03 2017 Don't show the Location Settings Dialog if the tab isn't interactable. If the tab for the web_contents that requested location isn't interactable, the Location Settings Dialog shouldn't be shown. This could happen if the user changed tabs, is in the tab switcher, or if Chrome isn't active. BUG= 710255 Review-Url: https://codereview.chromium.org/2817873002 Cr-Commit-Position: refs/heads/master@{#465795} [modify] https://crrev.com/b8a8a089caa1188776c83e4344df494d6f30b969/chrome/browser/geolocation/geolocation_permission_context_android.cc
,
Apr 21 2017
Tested on canary
,
Apr 21 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/196648220d843aa53efaf3f123ba49476f3f2f8c commit 196648220d843aa53efaf3f123ba49476f3f2f8c Author: Ben Wells <benwells@chromium.org> Date: Mon Apr 24 07:12:41 2017 Don't show the Location Settings Dialog if the tab isn't interactable. If the tab for the web_contents that requested location isn't interactable, the Location Settings Dialog shouldn't be shown. This could happen if the user changed tabs, is in the tab switcher, or if Chrome isn't active. BUG= 710255 Review-Url: https://codereview.chromium.org/2817873002 Cr-Commit-Position: refs/heads/master@{#465795} (cherry picked from commit b8a8a089caa1188776c83e4344df494d6f30b969) Review-Url: https://codereview.chromium.org/2835923002 . Cr-Commit-Position: refs/branch-heads/3071@{#156} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/196648220d843aa53efaf3f123ba49476f3f2f8c/chrome/browser/geolocation/geolocation_permission_context_android.cc
,
Apr 24 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by benwells@chromium.org
, Apr 13 2017