New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710253 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 713335
issue 713394
issue 772971

Blocking:
issue 713345



Sign in to add a comment

Clean up media.tough_video_cases and other media benchmarks and remove unnecessary pages

Project Member Reported by crouleau@chromium.org, Apr 10 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae7c8c0e3d01a2d73df388ffce7fb8045bcf0b0

commit 2ae7c8c0e3d01a2d73df388ffce7fb8045bcf0b0
Author: crouleau <crouleau@chromium.org>
Date: Tue Apr 11 23:37:56 2017

Organize tough_video_cases by adding tags describing media file format.

This is the first change. Later changes will remove unnecessary pages.

Design doc:
https://docs.google.com/document/d/1TvUWPl6diK3DTJdSWMOcdz-6qnKC6KEHAZqoBBD8lIc/edit#heading=h.j6gogx2lkhfb

BUG= 710253 

Review-Url: https://codereview.chromium.org/2814613002
Cr-Commit-Position: refs/heads/master@{#463836}

[modify] https://crrev.com/2ae7c8c0e3d01a2d73df388ffce7fb8045bcf0b0/tools/perf/page_sets/tough_video_cases.py

Cc: crouleau@chromium.org
 Issue 711125  has been merged into this issue.
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a48a45ac9c3138e306f19df0b3fc1974ffe33ec

commit 6a48a45ac9c3138e306f19df0b3fc1974ffe33ec
Author: crouleau <crouleau@chromium.org>
Date: Thu Apr 13 03:55:49 2017

Do not play the whole media file before seeking.

I also fixed some comments and fixed pylint line length errors.

This was a bug introduced in crrev/346923003.
Originally we would start playing the video and wait until it got to 1
second, and then we would seek around in it. After crrev/346923003 we
would instead play the entire video and then seek around in it.

sandersd@'s crrev/1962563005 noticed this bug and commented on it, but
we haven't gotten around to fixing it until now.

This change should reduce load on Speed infra machines by reducing the benchmark duration for tough_video_cases_extra from ~5 minutes to ~3 minutes. we get to skip the initial playback for 14 of the pages in tough_video_cases_extra. the video length of test content is around 10 seconds on average, and this change will make us play only 1 second of the video instead of the whole video before we start seeking. So 14*(10-1) = 126 seconds.

Also, I noticed that two of the pages in tough_video_cases are also seeking pages, not time_to_play pages, so this will reduce the runtime for those as well.

In addition to reducing the load, this change will also make seek times become the measurement that they were originally supposed to be. Seek time cold currently doesn't actually measure cold seek time because that part of the video that was seeked to was already played once.

BUG=  711125  

Review-Url: https://codereview.chromium.org/2813383002
Cr-Commit-Position: refs/heads/master@{#464288}

[modify] https://crrev.com/6a48a45ac9c3138e306f19df0b3fc1974ffe33ec/tools/perf/page_sets/tough_video_cases.py


The change above dropped the benchmark duration from 5 minutes to 2 minutes according to https://chromeperf.appspot.com/report?sid=6c9061b1943641a81dd022a50b91bac79d47ee995594e60788ab0da24e127e13 Not sure why my math was a little bit off: I predicted a drop from 5 to 3.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6f79e605ba482c827e07f30378eb5a61a43a677

commit e6f79e605ba482c827e07f30378eb5a61a43a677
Author: crouleau <crouleau@chromium.org>
Date: Fri Apr 14 00:45:33 2017

Remove audio_loop cases from tough_video_cases pagesets.

The only thing they measured was avg_loop_time. These tests are no longer needed since we have seek time metrics and
time_to_play metrics now.

This should reduce the benchmark_duration of media.tough_media_cases_extra by 140ms * 50 loops * 2 pages = 14 seconds.

A followup Catapult CL should remove now-unused code such as https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/actions/loop.py

Design doc: https://docs.google.com/document/d/1TvUWPl6diK3DTJdSWMOcdz-6qnKC6KEHAZqoBBD8lIc/edit#

BUG= 710253 

Review-Url: https://codereview.chromium.org/2822433004
Cr-Commit-Position: refs/heads/master@{#464629}

[modify] https://crrev.com/e6f79e605ba482c827e07f30378eb5a61a43a677/tools/perf/page_sets/tough_video_cases.py
[delete] https://crrev.com/bb76b686d4b7ed1fd7413a1f4ee17de4452d1ac0/tools/perf/page_sets/tough_video_cases/audio_playback.html
[delete] https://crrev.com/bb76b686d4b7ed1fd7413a1f4ee17de4452d1ac0/tools/perf/page_sets/tough_video_cases/pink_noise_140ms.wav.sha1
[delete] https://crrev.com/bb76b686d4b7ed1fd7413a1f4ee17de4452d1ac0/tools/perf/page_sets/tough_video_cases/pink_noise_20s.wav.sha1

Blocking: 713345
Labels: -Pri-2 Pri-1
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/597f6ab23b8535ca35d128e25bb0f57398e6da37

commit 597f6ab23b8535ca35d128e25bb0f57398e6da37
Author: crouleau <crouleau@chromium.org>
Date: Thu Apr 20 22:08:10 2017

Remove legacy codecs coverage from tough_video_cases pageset.

This reduces the number of pages from 38 to 27: 29% reduction. Hopefully that will reduce benchmark_duration a similar amount.

BUG= 710253 

Review-Url: https://codereview.chromium.org/2830953004
Cr-Commit-Position: refs/heads/master@{#466156}

[modify] https://crrev.com/597f6ab23b8535ca35d128e25bb0f57398e6da37/tools/perf/benchmarks/media.py
[modify] https://crrev.com/597f6ab23b8535ca35d128e25bb0f57398e6da37/tools/perf/page_sets/tough_video_cases.py
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/bear.webm.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/crowd.wav.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/crowd1080.ogv.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/crowd2160.mp4.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/crowd2160.webm.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/crowd360.ogv.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/crowd480.webm.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/crowd720.webm.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/garden2_10s.ogv.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/tulip2.ogv.sha1
[delete] https://crrev.com/af1a7293891126674d93ef0525868bd6287d491e/tools/perf/page_sets/tough_video_cases/tulip2.webm.sha1

Summary: Clean up media.tough_video_cases and other media benchmarks and remove unnecessary pages (was: Clean up media.tough_video_cases and remove unnecessary pages)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4207948af983aac15311f65b7d8b7b23c69614e9

commit 4207948af983aac15311f65b7d8b7b23c69614e9
Author: crouleau <crouleau@chromium.org>
Date: Wed Apr 26 20:04:23 2017

Disable media_cns_cases, add owners and components to all media benchmarks.

BUG= 676345 , 710253 

Review-Url: https://codereview.chromium.org/2842223002
Cr-Commit-Position: refs/heads/master@{#467422}

[modify] https://crrev.com/4207948af983aac15311f65b7d8b7b23c69614e9/tools/perf/benchmarks/media.py

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d623449fa0d8e402dea243355a411b7cdcffc5d

commit 4d623449fa0d8e402dea243355a411b7cdcffc5d
Author: crouleau <crouleau@chromium.org>
Date: Fri Apr 28 03:54:09 2017

Remove support for canvas element in tough_video_cases.

The canvas element simply mirrors the video element by grabbing frames from it.

Removing these 3 pages should reduce benchmark_duration for tough_video_cases by ~17%.

BUG= 710253 

Review-Url: https://codereview.chromium.org/2848723003
Cr-Commit-Position: refs/heads/master@{#467880}

[modify] https://crrev.com/4d623449fa0d8e402dea243355a411b7cdcffc5d/tools/perf/page_sets/tough_video_cases.py
[modify] https://crrev.com/4d623449fa0d8e402dea243355a411b7cdcffc5d/tools/perf/page_sets/tough_video_cases/video.html

Blockedon: 713394
Labels: -Pri-1 Pri-2
media.tough_video_cases benchmark_duration is down from 7.9 to 4.3

media.tough_video_cases_extra benchmark_duration is down from 8.9 to .9 (soon will merge tough_video_cases_extra into tough_video_cases)

media.android.tough_video_cases benchmark_duration is down from 12.5 to 7.1

media.android.tough_video_cases_tbmv2 benchmark_duration is down from 9.2 to 6

Lowering this from P1 to P2 since the situation is much better now (though more will is still in progress!)
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f243d9ff32782239f6d6c49c9c9fab2ca5021d2

commit 8f243d9ff32782239f6d6c49c9c9fab2ca5021d2
Author: crouleau <crouleau@chromium.org>
Date: Fri Jun 09 18:26:36 2017

Remove Page35 "crowd720_vp9.webm&seek" since not needed.

Also, removing this will help with crbug/720514 to show that the test
case itself is not the root cause of the bug. (Or if it is the root
cause, then this will fix that bug.)

crowd720_vp9.webm&seek is not needed since we have tulip2.vp9.webm&seek
and crowd1080_vp9.webm&seek. Those two page provide enough vp9 coverage
to make up for this removal.

BUG=720514, 710253 

Review-Url: https://codereview.chromium.org/2929003003
Cr-Commit-Position: refs/heads/master@{#478341}

[modify] https://crrev.com/8f243d9ff32782239f6d6c49c9c9fab2ca5021d2/tools/perf/page_sets/tough_video_cases.py

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/454b29bb89471156174c8769692ec607f8209f94

commit 454b29bb89471156174c8769692ec607f8209f94
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Wed Sep 27 01:20:46 2017

Simplify tough_video_cases page declarations.


Bug:  710253 
Change-Id: If3605e5335292ee8f22d8caaf7f6e5f701301a84
Reviewed-on: https://chromium-review.googlesource.com/685491
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#504540}
[modify] https://crrev.com/454b29bb89471156174c8769692ec607f8209f94/tools/perf/page_sets/tough_video_cases.py

Blockedon: 713335
Blockedon: 772971
Status: Fixed (was: Assigned)
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment