Move error page/interstitial/SSL page detection away from archiver |
|||
Issue descriptionThis type of logic seems to be better fit inside the Offliner instead
,
Apr 11 2017
So it will be perfectly OK to save an offline page for a bad ssl page from the tab? Does that sound like the right approach?
,
Apr 11 2017
I personally think the Archiver is a good place to put this "catch-all", which this technically is. SSL pages should have resulted in an SSL error on navigation in both the background loader and the recent tab helper, so control should never get to this place in the first place. The catch-all for error, interstitial, and SSL pages are currently here more for prerenderer than anything else. If we see a large number of pages from recent tab helper or background loader that was blocked due to these checks, that should be an indication something is not right and we should investigate. Pete's idea was that the offliner should not have let the page save in the first place, so the logic should go in the offliner/tab helper. This also has its merits, and we should talk about/consider once we're not longer worried about prerenderer
,
Mar 29 2018
Should we just close this? |
|||
►
Sign in to add a comment |
|||
Comment 1 by petewil@chromium.org
, Apr 10 2017