Orientation change jank on media using custom controls in fullscreen |
||||
Issue descriptionChrome Version: Repros on Stable, Beta, Dev and Canary OS: Android N, Android O What steps will reproduce the problem? (1) Find a video on CNN and hit play (http://www.cnn.com/videos/politics/2017/04/10/alabama-governor-bentley-news-conference-sot.wsfa) (2) Enter fullscreen (3) Change the orientation What is the expected result? Orientation change is smooth What happens instead? Orientation change has a lot of shifting and flashing This happens not just on CNN, but also the internal PWA media app we are building. https://biograf-155113.appspot.com/chrome-channel/trailer/ Even though it is 100% repro on these sites, it doesn't happen on all sites that use custom controls. For example, Cricbuzz doesn't have any issues. http://www.cricbuzz.com/cricket-videos/3543/ipl-memories-ms-dhonis-blitzkrieg-in-dharamsala-takes-csk-into-the-semis. This is not observed on sites that use native controls. Here are some slo mo repro videos: CNN: https://goo.gl/photos/uYmXUiXEVHkSfFRFA PWA: https://goo.gl/photos/SJn2StA3UUT4gtVDA Assigning to Tommy to investigate as part of the broader fullscreen/orientation jank issue.
,
Apr 21 2017
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88f9d604d77b922af3117d72a2433a67ccdf1a46 commit 88f9d604d77b922af3117d72a2433a67ccdf1a46 Author: steimel <steimel@chromium.org> Date: Wed Jul 12 20:56:46 2017 Hide fullscreen rotation jank on Android In order to hide the jank that is shown during fullscreen rotations, evict the frame and show a black screen while in fullscreen when the frame size doesn't match the physical backing size. This change also clears the thumbnail cache of the tab when entering fullscreen so that the thumbnail isn't shown when the frame is evicted. BUG= 710243 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2810813004 Cr-Commit-Position: refs/heads/master@{#486080} [modify] https://crrev.com/88f9d604d77b922af3117d72a2433a67ccdf1a46/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/88f9d604d77b922af3117d72a2433a67ccdf1a46/chrome/browser/android/compositor/tab_content_manager.cc [modify] https://crrev.com/88f9d604d77b922af3117d72a2433a67ccdf1a46/chrome/browser/android/compositor/tab_content_manager.h [modify] https://crrev.com/88f9d604d77b922af3117d72a2433a67ccdf1a46/chrome/browser/android/tab_android.cc [modify] https://crrev.com/88f9d604d77b922af3117d72a2433a67ccdf1a46/chrome/browser/android/tab_android.h [modify] https://crrev.com/88f9d604d77b922af3117d72a2433a67ccdf1a46/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/88f9d604d77b922af3117d72a2433a67ccdf1a46/content/browser/renderer_host/render_widget_host_view_android.h
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7f3b08d03bd86193306bef2367ae73bdb70217c commit f7f3b08d03bd86193306bef2367ae73bdb70217c Author: Tommy Steimel <steimel@chromium.org> Date: Thu Jul 20 14:03:34 2017 Add feature flag for hiding incorrectly-sized fullscreen frames Bug: 710243 Change-Id: If8fe0c711f1c5e81888fcff9190497a1319e20db Reviewed-on: https://chromium-review.googlesource.com/577976 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Alexandre Elias <aelias@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#488232} [modify] https://crrev.com/f7f3b08d03bd86193306bef2367ae73bdb70217c/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/f7f3b08d03bd86193306bef2367ae73bdb70217c/content/public/common/content_features.cc [modify] https://crrev.com/f7f3b08d03bd86193306bef2367ae73bdb70217c/content/public/common/content_features.h
,
Aug 8 2017
Issue 544269 has been merged into this issue.
,
Oct 2 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dah...@chromium.org
, Apr 10 2017