New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710241 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

chromeos_unittests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Project Member Reported by hongchan@chromium.org, Apr 10 2017

Issue description

chromeos_unittests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Builders failed on: 
- Linux ChromiumOS Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29

stevenjb@

Could you take a look at these failures? Couldn't find the culprit CL, so forward the issue to the file owner.

ManagedNetworkConfigurationHandlerTest.PolicyApplicationRunning
ManagedNetworkConfigurationHandlerTest.SetPolicyReapplyToManaged
ManagedNetworkConfigurationHandlerTest.SetPolicyUpdateManagedNewGUID
ManagedNetworkConfigurationHandlerTest.UpdatePolicyAfterFinished
 
Labels: -Sheriff-Chromium
Status: Assigned (was: Available)
Cc: alemate@chromium.org brettw@chromium.org khmel@chromium.org
+gardeners

This was introduced here: https://codereview.chromium.org/2807953002

But I suspect it is a legitimate problem with the tests.

I can investigate first thing tomorrow, but these builders will be red overnight (I have to leave for the day).

Comment 3 by mkwst@chromium.org, Apr 11 2017

Labels: OS-Chrome
Leaving the tree red overnight is not a great solution. :(

I'm disabling the failing tests in https://codereview.chromium.org/2814443006, TBRing stevenjb@.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12c17683df6cc8bbb32bcc6ab375c8d3901ee258

commit 12c17683df6cc8bbb32bcc6ab375c8d3901ee258
Author: mkwst <mkwst@chromium.org>
Date: Tue Apr 11 07:28:26 2017

Disabling several ChromeOS tests.

After https://codereview.chromium.org/2807953002, several ChromeOS tests
started failing. This patch disables the following:

* NetworkingPrivateChromeOSApiTest.GetManagedProperties
* ManagedNetworkConfigurationHandlerTest.PolicyApplicationRunning
* ManagedNetworkConfigurationHandlerTest.SetPolicyReapplyToManaged
* ManagedNetworkConfigurationHandlerTest.SetPolicyUpdateManagedNewGUID
* ManagedNetworkConfigurationHandlerTest.UpdatePolicyAfterFinished

BUG= 710241 
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2814443006
Cr-Commit-Position: refs/heads/master@{#463564}

[modify] https://crrev.com/12c17683df6cc8bbb32bcc6ab375c8d3901ee258/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/12c17683df6cc8bbb32bcc6ab375c8d3901ee258/chromeos/network/managed_network_configuration_handler_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e4bc12318fac3839ddf6f0b69dcbd5bfd962b56

commit 6e4bc12318fac3839ddf6f0b69dcbd5bfd962b56
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Apr 11 21:45:54 2017

Fix policy_util iterator and re-enable networking tests

This fixes a DCHECK that exposed a poor assumption in
RemoveFakeCredentials about DictionaryValue iteration. It was exposed
with this CL:
https://codereview.chromium.org/2807953002

It also re-enables tests the disabled tests.

BUG= 710241 

Review-Url: https://codereview.chromium.org/2810703005
Cr-Commit-Position: refs/heads/master@{#463783}

[modify] https://crrev.com/6e4bc12318fac3839ddf6f0b69dcbd5bfd962b56/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/6e4bc12318fac3839ddf6f0b69dcbd5bfd962b56/chromeos/network/managed_network_configuration_handler_unittest.cc
[modify] https://crrev.com/6e4bc12318fac3839ddf6f0b69dcbd5bfd962b56/chromeos/network/policy_util.cc

Status: Fixed (was: Assigned)

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment