New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710238 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

VPN and WiFi status not correctly reflected after connecting / disconnecting WiFi/ VPN service

Project Member Reported by aashuto...@chromium.org, Apr 10 2017

Issue description

Chrome Version: <From about:version: Google Chrome 59.0.3055.0>
Chrome OS Version: <From about:version: Platform 9433.0.0>
Chrome OS Platform: <Samus>
Network info: <WiFi/VPN)>

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Connect to a OpenVPN service.
(2) Go to Chrome://settings, click VPN and navigate to currently connected service. 

Expected Result: OpenVPN service should show up as connected. 

Actual Result: OpenVPN service should show up as not connected

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always. 

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.
Screenshot Attached. 

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
screenshot.pdf
124 KB Download

Comment 1 Deleted

Labels: Needs-Feedback
Status: Assigned (was: Untriaged)
I am unable to reproduce this.

aashutoshk@: If you can still reproduce this, could you please do the following:

1. Open the JS console in the md-settings/networkDetail page and copy/paste any error text and/or include a screenshot.
2. File a feedback report and include a link to it here (or username + report text to search for)

Cc: steve...@chromium.org
Owner: aashuto...@chromium.org
Also, do you have a test VPN server set up that I can test against?

Yes, I do but it is not connected to the corp network. you need to be physically here to connect to a network which can access to the VPN service. 
Summary: VPN and WiFi status not correctly reflected after connecting / disconnecting WiFi/ VPN service (was: VPN status not correctly reflected after connecting / disconnecting VPN service)
I am seeing this even for WiFi networks. 
JS console :
Unexpected networkingPrivate.startConnect error: connect-canceledFor: 37321550-228f-4eeb-b6e4-ae6f39f705c1
Unexpected networkingPrivate.startConnect error: connectedFor: 2a6512cd-ca1a-482b-aa60-345c5663a567
Screenshots attached. 
Screenshot 2017-04-21 at 5.28.54 PM.png
1.9 MB View Download
Screenshot 2017-04-21 at 5.29.05 PM.png
1.5 MB View Download
Labels: M-60
Cc: aashuto...@chromium.org
Labels: -Pri-2 -M-60 Pri-1
Owner: steve...@chromium.org
OK, the JS console errors help, looks like there is a case we are not handling correctly.

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/382dc5ad70e096a8df3fea9c80e47e372bb04d00

commit 382dc5ad70e096a8df3fea9c80e47e372bb04d00
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Apr 25 22:05:25 2017

MD Settings: Fix networking config errors

This CL:
* Correctly handles errors from chrome when a guid becomes
  stale.
* Updates EAP properties in the networking_private IDl and
  in onc_spec.md.
* Fixes networking_private_chromeos.cc to not set empty
  proxy values.

BUG=714210, 710238 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2839693003
Cr-Commit-Position: refs/heads/master@{#467131}

[modify] https://crrev.com/382dc5ad70e096a8df3fea9c80e47e372bb04d00/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/382dc5ad70e096a8df3fea9c80e47e372bb04d00/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/382dc5ad70e096a8df3fea9c80e47e372bb04d00/chromeos/network/onc/onc_signature.cc
[modify] https://crrev.com/382dc5ad70e096a8df3fea9c80e47e372bb04d00/components/onc/docs/onc_spec.md
[modify] https://crrev.com/382dc5ad70e096a8df3fea9c80e47e372bb04d00/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/382dc5ad70e096a8df3fea9c80e47e372bb04d00/extensions/common/api/networking_onc.idl
[modify] https://crrev.com/382dc5ad70e096a8df3fea9c80e47e372bb04d00/extensions/common/api/networking_private.idl
[modify] https://crrev.com/382dc5ad70e096a8df3fea9c80e47e372bb04d00/third_party/closure_compiler/externs/networking_private.js

Status: Fixed (was: Started)
Labels: Merge-Request-59
This causes pretty bad behavior, we should merge this to 59. The changes are entirely Chrome OS specific.
Labels: Merge-Approved-59
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 26 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59

commit 8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Apr 26 21:21:26 2017

MD Settings: Fix networking config errors

This CL:
* Correctly handles errors from chrome when a guid becomes
  stale.
* Updates EAP properties in the networking_private IDl and
  in onc_spec.md.
* Fixes networking_private_chromeos.cc to not set empty
  proxy values.

BUG=714210, 710238 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2839693003
Cr-Commit-Position: refs/heads/master@{#467131}
(cherry picked from commit 382dc5ad70e096a8df3fea9c80e47e372bb04d00)

Review-Url: https://codereview.chromium.org/2843163002 .
Cr-Commit-Position: refs/branch-heads/3071@{#236}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59/chromeos/network/onc/onc_signature.cc
[modify] https://crrev.com/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59/components/onc/docs/onc_spec.md
[modify] https://crrev.com/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59/extensions/common/api/networking_onc.idl
[modify] https://crrev.com/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59/extensions/common/api/networking_private.idl
[modify] https://crrev.com/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59/third_party/closure_compiler/externs/networking_private.js

Project Member

Comment 14 by sheriffbot@chromium.org, Apr 27 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by sheriffbot@chromium.org, May 1 2017

Cc: gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-59

Comment 17 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment