New issue
Advanced search Search tips

Issue 710233 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 709987
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

FrameView::layout() incorrectly renamed to GetLayout() even though it's a verb

Project Member Reported by esprehn@chromium.org, Apr 10 2017

Issue description

This method is a verb, it should be Layout(), it seems to have been prefixed with "Get" in the rename incorrectly.
 
This seems to have happened all over the codebase, for example LayoutObject::layout() also became ::GetLayout() which is very confusing.
Worse:

  void GetLayoutBlock(bool relayout_children) override;

Comment 3 by dcheng@chromium.org, Apr 10 2017

Mergedinto: 709987
Status: Duplicate (was: Untriaged)

Sign in to add a comment