I ran this test on my Windows 10 machine, and it passed. I tried both run-webkit-tests and running content_shell directly with the following output:



C:\src\chrome\src\third_party\WebKit> Tools\Scripts\run-webkit-tests -t GnDebug external\wpt\css\cssom-view-1\MediaQueryList-001.html
Using port 'win-win10'
Test configuration: <win10, x86, debug>
View the test results at file://C:\src\chrome\src\out\GnDebug\layout-test-results/results.html
View the archived results dashboard at file://C:\src\chrome\src\out\GnDebug\layout-test-results/dashboard.html
Using random order with seed: 1491885795
Baseline search path: win -> generic
Using Debug build
Pixel tests enabled
Regular timeout: 18000, slow test timeout: 90000
Command line: C:\src\chrome\src\out\GnDebug\content_shell.exe --run-layout-test --enable-direct-write --enable-crash-reporter --crash-dumps-dir=C:\src\chrome\src\out\GnDebug\crash-dumps -

Found 1 test; running 1, skipping 0.

Ruby is not installed; can't generate pretty patches.

Running 1 content_shell.

The test ran as expected.

- or -

C:\src\chrome\src> out\GnDebug\content_shell.exe --run-layout-test --no-sandbox third_party\WebKit\LayoutTests\external\wpt\css\cssom-view-1\MediaQueryList-001.html

C:\src\chrome\src>#READY
Content-Type: text/plain
This is a testharness.js-based test.
PASS matchMedia
Harness: the test ran to completion.

#EOF
#EOF
#EOF



It sounds like the test is testing matchMedia output expecting a particular device aspect ratio, which seems brittle. Do we really ever want to have this test?

[1] https://developer.mozilla.org/en/docs/Web/API/Window/matchMedia

It's a little hard to track who added that test because of the csswg-test merge, but as far as I know:
 - The tests should test conformance to a spec.
 - The tests should be broadly applicable to different browsers, devices, & platforms.

It seems like this test is just testing making any query with window.matchMedia. Could this test be changed so that the query can be expected to always evaluate to true on all devices?

Like, what about changing the query to window.matchMedia("(min-width: 1px)")?

If we make this change, we should get feedback from @plinss and @zcorpan.

Thank you for providing more feedback. Adding requester "meade@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

> Like, what about changing the query to window.matchMedia("(min-width: 1px)")?

That seems very reasonable.

Hi qyearsley, could you add @plinss to cc so we can get feedback about this? Thanks!

Can't find the email address of @plinss :-/ Made an issue on GitHub: https://github.com/w3c/web-platform-tests/issues/5541

I think this should not be blocking on feedback from plinss. He didn't write the test and is not directly involved in cssom-view. You have received positive feedback from me already.

Ok, how about we just fix it then.

I just posted https://codereview.chromium.org/2829913003 :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0380ef0910a520f4336ba3e8d3c6fdcc007e5cee

commit 0380ef0910a520f4336ba3e8d3c6fdcc007e5cee
Author: meade <meade@chromium.org>
Date: Mon Apr 24 01:02:50 2017

Change MediaQueryList-001 to test on min-width: 1px

This is instead of the device aspect ratio, as that is brittle.

BUG= 710226 

Review-Url: https://codereview.chromium.org/2829913003
Cr-Commit-Position: refs/heads/master@{#466573}

[modify] https://crrev.com/0380ef0910a520f4336ba3e8d3c6fdcc007e5cee/third_party/WebKit/LayoutTests/external/wpt/cssom-view/MediaQueryList-001.html

Oops, realised I still need re-enable the test.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3051352e6cf8653c74a8b163d166eebe57feb42

commit d3051352e6cf8653c74a8b163d166eebe57feb42
Author: meade <meade@chromium.org>
Date: Fri May 05 03:47:15 2017

Re-enable external/wpt/cssom-view/MediaQueryList-001.html

Now that I've changed it to be less brittle, this should just work.
(see https://codereview.chromium.org/2829913003)

BUG= 710226 

Review-Url: https://codereview.chromium.org/2864593002
Cr-Commit-Position: refs/heads/master@{#469589}

[modify] https://crrev.com/d3051352e6cf8653c74a8b163d166eebe57feb42/third_party/WebKit/LayoutTests/TestExpectations