New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710225 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

Make dropdown overlays have 12px left/right padding

Project Member Reported by tbuck...@chromium.org, Apr 10 2017

Issue description

The overlay that appears when a dropdown is open should have 12px of left/right padding. The text of the dropdown button, text within the overlay, and the button underline should be all left-aligned (in LTR). It is okay if the click target of the dropdown button 
 
Screenshot 2017-04-10 at 3.21.49 PM.png
27.7 KB View Download
Blocking: 671375

Comment 2 by dbeam@chromium.org, Apr 10 2017

Cc: -dbeam@chromium.org dpa...@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Available)

Comment 3 by dpa...@chromium.org, Apr 11 2017

FYI, in case it helps, here is the diff I had when I demoed to tbuckley@ and dbeam@ last week https://pastebin.com/RTDWtsfj (see screenshot too).
md_select_extra_padding.png
8.4 KB View Download

Comment 4 by dbeam@chromium.org, Apr 11 2017

md_select_linux.png
17.3 KB View Download
2017-04-10-204704_255x203_scrot.png
8.7 KB View Download

Comment 5 by bettes@chromium.org, Apr 11 2017

LGTM

Comment 6 by dbeam@chromium.org, Apr 11 2017

Owner: dpa...@chromium.org
dpapad@ has a slightly slimmer solution

Comment 7 by dpa...@chromium.org, Apr 11 2017

Cc: ranjitkan@chromium.org scottchen@chromium.org tbuck...@chromium.org esprehn@chromium.org nyerramilli@chromium.org steve...@chromium.org tkonch...@chromium.org dbeam@chromium.org
 Issue 654323  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32ea48de49d9ad146142956362b8b2d4a6234d75

commit 32ea48de49d9ad146142956362b8b2d4a6234d75
Author: dpapad <dpapad@chromium.org>
Date: Wed Apr 12 01:39:21 2017

WebUI: Add left/right padding on md-select.

 - Remove bottom border (underline) from md-select.
 - Repurpose md-select-underline two hold both underlines
   (persistent as ::before, focus as ::after).
 - Add 12px margin left/right.

BUG= 710225 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814813002
Cr-Commit-Position: refs/heads/master@{#463883}

[modify] https://crrev.com/32ea48de49d9ad146142956362b8b2d4a6234d75/ui/webui/resources/html/md_select_css.html

Comment 9 by dpa...@chromium.org, Apr 12 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9534.0.0, 60.0.3092.0

Sign in to add a comment