adjust overlay position for compositor screen position |
|||
Issue descriptionDialogOverlayImpl currently sets the dialog's screen position using the coordinates requested by the application directly. However, they're going to be in compositor coordinates, rather than screen coordinates. If the compositor is offset from the screen origin, such as by the android status bar, then the overlay will be in the wrong spot. the embedder could provide the results of View.getLocationOnScreen(), which would serve as the offset.
,
Jun 22 2017
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6c179267fc346b4a5809ec598e877e1515db419 commit d6c179267fc346b4a5809ec598e877e1515db419 Author: liberato@chromium.org <liberato@chromium.org> Date: Mon Jun 26 22:54:55 2017 Added CompositorView screen offset to overlay positions. This CL exposes the compositor's screen coordinates on Android, so that DialogOverlayImpl can adjust the layout position to match with whatever the on-screen offset of the compositor is. This makes overlays line up properly even if, e.g., the Android status bar offsets the compositor. Bug: 710201 Change-Id: I1d67d3b0dfa1f65052fc3a9e60a8d4c5a1bdf7c4 Reviewed-on: https://chromium-review.googlesource.com/544538 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#482446} [modify] https://crrev.com/d6c179267fc346b4a5809ec598e877e1515db419/content/browser/android/dialog_overlay_impl.cc [modify] https://crrev.com/d6c179267fc346b4a5809ec598e877e1515db419/content/browser/android/dialog_overlay_impl.h [modify] https://crrev.com/d6c179267fc346b4a5809ec598e877e1515db419/content/public/android/java/src/org/chromium/content/browser/androidoverlay/DialogOverlayImpl.java [modify] https://crrev.com/d6c179267fc346b4a5809ec598e877e1515db419/ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java [modify] https://crrev.com/d6c179267fc346b4a5809ec598e877e1515db419/ui/android/view_android.cc [modify] https://crrev.com/d6c179267fc346b4a5809ec598e877e1515db419/ui/android/view_android.h
,
Jun 26 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by liber...@chromium.org
, Jun 22 2017Owner: liber...@chromium.org
Status: Started (was: Available)