New issue
Advanced search Search tips

Issue 710175 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Improve payments strings

Project Member Reported by gogerald@chromium.org, Apr 10 2017

Issue description

^^^

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2017

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/860f7b94d494e56b79f9eb0de666e3055d19b309

commit 860f7b94d494e56b79f9eb0de666e3055d19b309
Author: mkwst <mkwst@chromium.org>
Date: Tue Apr 11 07:06:14 2017

Revert of [Payments] update strings (patchset #2 id:40001 of https://codereview.chromium.org/2812523004/ )

Reason for revert:
This broke some Android tests in https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/40425 (I guess they have hard-coded strings?)

Original issue's description:
> update strings
>
> Update payments related strings according to this doc:
> https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxdRMyD2t4EMCzpxcY/edit?usp=sharing
>
> BUG= 710175 
>
> Review-Url: https://codereview.chromium.org/2812523004
> Cr-Commit-Position: refs/heads/master@{#463462}
> Committed: https://chromium.googlesource.com/chromium/src/+/36b88dcdf796a4bd6b2442f11a44d453c54d7e65

TBR=srahim@chromium.org,rouslan@chromium.org,gogerald@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 710175 

Review-Url: https://codereview.chromium.org/2814623003
Cr-Commit-Position: refs/heads/master@{#463558}

[modify] https://crrev.com/860f7b94d494e56b79f9eb0de666e3055d19b309/components/payments_strings.grdp

Status: Fixed (was: Untriaged)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment