Issue metadata
Sign in to add a comment
|
Line appears above touch position |
||||||||||||||||||||||
Issue descriptionKeep version: 3.2.17144.1262 Chrome OS version: 59.0.3054.0 (Official Build) dev (64-bit) Repro (sometimes, maybe 2/3): 1) Open Keep 2) Create lots of content so the drawing note has to be scrolled to. 3) Scroll to drawing note. 3) Create a drawing note and write. Note that line appears at correct points. 4) Back out of drawing and click "Done" on note 5) Open note again 6) Tap drawing to edit 7) Draw with stylus/touch Expected: line appears at same point as stylus/touch Actual: line appears above stylus/touch by 1-3 inches or so
,
Apr 11 2017
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b452deb2b1802b68bf9662308074e4b10904f709 commit b452deb2b1802b68bf9662308074e4b10904f709 Author: dtapuska <dtapuska@chromium.org> Date: Wed Apr 12 22:13:23 2017 Fix frame coordinate translation issue with scroll views. The absolute position was being used (which is in content coordinates) but we were passing the root frame coordinates in. Translate the root frame coordinates into content coordinates before applying the transform from the LayoutObject. This matches the implementation of RootFrameToLocalPoint methods. BUG= 710165 Review-Url: https://codereview.chromium.org/2814473003 Cr-Commit-Position: refs/heads/master@{#464170} [modify] https://crrev.com/b452deb2b1802b68bf9662308074e4b10904f709/third_party/WebKit/Source/web/WebInputEventConversion.cpp [modify] https://crrev.com/b452deb2b1802b68bf9662308074e4b10904f709/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp [modify] https://crrev.com/b452deb2b1802b68bf9662308074e4b10904f709/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp [add] https://crrev.com/b452deb2b1802b68bf9662308074e4b10904f709/third_party/WebKit/Source/web/tests/data/plugin_scroll.html
,
Apr 13 2017
,
Apr 13 2017
Verified on Canary 59.0.3070.0 Windows 10 with touch.
,
Apr 13 2017
Approved for M58
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e64f95fdc842b8a37fa12ab375f82805f87f32d0 commit e64f95fdc842b8a37fa12ab375f82805f87f32d0 Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Apr 13 19:48:41 2017 Fix frame coordinate translation issue with scroll views. The absolute position was being used (which is in content coordinates) but we were passing the root frame coordinates in. Translate the root frame coordinates into content coordinates before applying the transform from the LayoutObject. This matches the implementation of RootFrameToLocalPoint methods. BUG= 710165 Review-Url: https://codereview.chromium.org/2814473003 Cr-Commit-Position: refs/heads/master@{#464170} (cherry picked from commit d99b8375dd7a1f9f69f8bcc5bde50ad2669b2b72) Review-Url: https://codereview.chromium.org/2813903006 . Cr-Commit-Position: refs/branch-heads/3029@{#695} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/e64f95fdc842b8a37fa12ab375f82805f87f32d0/third_party/WebKit/Source/web/WebInputEventConversion.cpp [modify] https://crrev.com/e64f95fdc842b8a37fa12ab375f82805f87f32d0/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp [modify] https://crrev.com/e64f95fdc842b8a37fa12ab375f82805f87f32d0/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp [add] https://crrev.com/e64f95fdc842b8a37fa12ab375f82805f87f32d0/third_party/WebKit/Source/web/tests/data/plugin_scroll.html
,
Apr 13 2017
,
Apr 19 2017
Tested the issue on windows 10 touch machine using chrome version 58.0.3029.81.with the steps from comment #0.Observed line appears at same point as touch/stylus. But also seen the same behaviour on chrome version 59.0.3054.0 also. dtapuska@ Could you please find the attached screen cast and confirm if anything missed here. Thanks,
,
Apr 19 2017
No you didn't add a bunch of notes first and scroll the main document to get to the note that has your drawing. It appears you only have one note visible. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tbuck...@chromium.org
, Apr 10 2017