New issue
Advanced search Search tips

Issue 710159 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

app menu button borders don't match separators

Project Member Reported by est...@chromium.org, Apr 10 2017

Issue description

There are a couple discrepancies between how we draw the vertical separators for buttons and how the normal horizontal ones are drawn. I propose we eliminate these differences.
 
a6dnGdkMN8j.png
22.6 KB View Download
fJWUypXYXPP (1).png
19.0 KB View Download

Comment 1 by est...@chromium.org, Apr 10 2017

Components: UI>Browser>Toolbar Internals>Views>Desktop
Labels: -Pri-3 OS-Chrome OS-Linux OS-Windows Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/944eab72bd2c478b03195680ef033b1d88aa85cc

commit 944eab72bd2c478b03195680ef033b1d88aa85cc
Author: estade <estade@chromium.org>
Date: Mon Apr 17 16:39:06 2017

Use NativeTheme to draw vertical menu separators.

Use NativeTheme to draw vertical menu separators ("menu button border")
so that they look like native horizontal separators instead of being
subtly different.

For now the GTK theme doesn't have a way to draw vertical separators,
so the old way of doing things (SkCanvas::drawRect) is retained, just
moved from app_menu.cc to native_theme_gtk3.cc.

BUG= 710159 
TBR=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2813703003
Cr-Commit-Position: refs/heads/master@{#464930}

[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/chrome/browser/ui/libgtkui/native_theme_gtk2.cc
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/chrome/browser/ui/libgtkui/native_theme_gtk3.cc
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/ui/base/models/menu_separator_types.h
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/ui/native_theme/common_theme.cc
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/ui/native_theme/native_theme.h
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/ui/native_theme/native_theme_dark_aura.cc
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/ui/native_theme/native_theme_mac.mm
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/ui/native_theme/native_theme_win.cc
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/ui/native_theme/native_theme_win.h
[modify] https://crrev.com/944eab72bd2c478b03195680ef033b1d88aa85cc/ui/views/controls/menu/menu_separator.cc

Comment 3 by est...@chromium.org, Apr 17 2017

Status: Fixed (was: Started)
we'll still need to do some work for various scale factors, but at least the vertical and horizontal separators are now the same.

Sign in to add a comment