New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710158 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Delete logPrivate

Project Member Reported by r...@chromium.org, Apr 10 2017

Issue description

The logPrivate API was put in for use by CfM. It is apparently not being used anywhere at all at this time.

Given that we have the newer feedbackPrivate.getSystemInformation API, which is actually in use by CfM, there is no longer any need for logPrivate.

We should delete this API and all related code and reduce our bloat.

 

Comment 1 by r...@chromium.org, Apr 10 2017

Cc: xiy...@chromium.org afakhry@chromium.org
Labels: -Pri-2 Pri-1
Cc: r...@chromium.org
Labels: -M-60 M-61
Owner: afakhry@chromium.org
Status: Started (was: Assigned)
I can take this on.

Comment 3 by r...@chromium.org, Jun 13 2017

Sweet!

It seems to be used by a couple of kiosk test apps [1] [2].

Those exist on the webstore. I'm unable to find their owners. rkc@ do you know who we should contact? Are we fine with breaking those?

[1]: https://cs.corp.google.com/webstore/crx/j/jemphejnhceekmkfagjgpegngilghefb/main.js?q=dumpLogs%5C(+f:.*%5C.js&dr=C&l=167

[2]: https://cs.corp.google.com/webstore/crx/o/ojddfmahcjbeeoikmfpikoickcjebmcn/application.js?q=dumpLogs%5C(+f:.*%5C.js&dr=C&l=4
Neither of those seem to be in the API whitelist, so I'd guess they are already broken (well, unless they're used in some custom setup).

Comment 6 by r...@chromium.org, Jun 13 2017

Both of those are test apps - I suspect created to test this API :)
Feel free to ignore them and nuke the API.

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4657c6480527b4b1ea6cb21d4d666ea92652f04d

commit 4657c6480527b4b1ea6cb21d4d666ea92652f04d
Author: afakhry <afakhry@chromium.org>
Date: Thu Jun 15 21:58:35 2017

Delete the logPrivate APIs

This API is not used and can be replaced by the newer
feedbackPrivate.getSystemInformation APIs.

BUG= 710158 

Review-Url: https://codereview.chromium.org/2934163002
Cr-Commit-Position: refs/heads/master@{#479855}

[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/browser/extensions/BUILD.gn
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/filter_handler.cc
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/filter_handler.h
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/log_parser.cc
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/log_parser.h
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/log_private_api.h
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/syslog_parser.cc
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/syslog_parser.h
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/browser/extensions/api/log_private/syslog_parser_unittest.cc
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/common/extensions/api/_permission_features.json
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/common/extensions/api/log_private.idl
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/common/extensions/docs/templates/public/apps/logPrivate.html
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/common/extensions/docs/templates/public/extensions/logPrivate.html
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/renderer/BUILD.gn
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/renderer/resources/extensions/log_private_custom_bindings.js
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/renderer/resources/renderer_resources.grd
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/chrome/test/BUILD.gn
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/test/data/extensions/api_test/log_private/dump_logs/manifest.json
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/test/data/extensions/api_test/log_private/dump_logs/system_logs.tar
[delete] https://crrev.com/14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3/chrome/test/data/extensions/api_test/log_private/dump_logs/test.js
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/4657c6480527b4b1ea6cb21d4d666ea92652f04d/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment