New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710150 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 713779
issue 713938



Sign in to add a comment

Implement native/skia-based WebVR warnings

Project Member Reported by cjgrant@chromium.org, Apr 10 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d871a9338a39d46cbb25ee6571a4e225f049bda1

commit d871a9338a39d46cbb25ee6571a4e225f049bda1
Author: cjgrant <cjgrant@chromium.org>
Date: Wed Apr 12 15:31:01 2017

VR: Rename ContentRectangle to UiElement

UiElements show arbitrary textures now, not just content. Generalize the
naming to avoid confusion.

BUG= 710150 

Review-Url: https://codereview.chromium.org/2807293002
Cr-Commit-Position: refs/heads/master@{#464033}

[modify] https://crrev.com/d871a9338a39d46cbb25ee6571a4e225f049bda1/chrome/browser/android/vr_shell/BUILD.gn
[rename] https://crrev.com/d871a9338a39d46cbb25ee6571a4e225f049bda1/chrome/browser/android/vr_shell/ui_element.cc
[rename] https://crrev.com/d871a9338a39d46cbb25ee6571a4e225f049bda1/chrome/browser/android/vr_shell/ui_element.h
[rename] https://crrev.com/d871a9338a39d46cbb25ee6571a4e225f049bda1/chrome/browser/android/vr_shell/ui_element_unittest.cc
[modify] https://crrev.com/d871a9338a39d46cbb25ee6571a4e225f049bda1/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/d871a9338a39d46cbb25ee6571a4e225f049bda1/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/d871a9338a39d46cbb25ee6571a4e225f049bda1/chrome/browser/android/vr_shell/ui_scene_unittest.cc
[modify] https://crrev.com/d871a9338a39d46cbb25ee6571a4e225f049bda1/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/d871a9338a39d46cbb25ee6571a4e225f049bda1/chrome/browser/android/vr_shell/vr_shell_gl.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157

commit e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157
Author: cjgrant <cjgrant@chromium.org>
Date: Wed Apr 12 17:53:12 2017

VR: Add a native UI element scene manager

- Mirror the concept of the HTML scene manager in native.
- Temporarily let both the HTML UI and native code manage elements.
- Future CLs will supply native-driven WebVR security warnings.

BUG= 710150 

Review-Url: https://codereview.chromium.org/2809143004
Cr-Commit-Position: refs/heads/master@{#464078}

[modify] https://crrev.com/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157/chrome/browser/android/vr_shell/ui_scene_manager.cc
[add] https://crrev.com/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157/chrome/browser/android/vr_shell/vr_shell_gl.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a332bf72eded671758da727bf530313696128ad3

commit a332bf72eded671758da727bf530313696128ad3
Author: cjgrant <cjgrant@chromium.org>
Date: Wed Apr 12 20:34:41 2017

VR: Add stub WebVR warnings.

This CL adds properly-positioned elements for the permanent and transient WebVR
warning. The elements are currently invisible, and will be made visible when
Skia rendering supplies their texture and exact size.

BUG= 710150 

Review-Url: https://codereview.chromium.org/2810963003
Cr-Commit-Position: refs/heads/master@{#464135}

[modify] https://crrev.com/a332bf72eded671758da727bf530313696128ad3/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/a332bf72eded671758da727bf530313696128ad3/chrome/browser/android/vr_shell/ui_scene_manager.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9cff176581d901a8b2b1fed51035c13418f87b9

commit d9cff176581d901a8b2b1fed51035c13418f87b9
Author: acondor <acondor@google.com>
Date: Thu Apr 13 20:20:44 2017

Rendering Insecure WebVR Warnings into a texture with Skia.

Icons and rounded backgrounds reuse gfx code.
Text rendering is a temporary solution that cannot handle fallback fonts.
RTL rendering is not handled either.

BUG= 710150 

Review-Url: https://codereview.chromium.org/2818553002
Cr-Commit-Position: refs/heads/master@{#464523}

[modify] https://crrev.com/d9cff176581d901a8b2b1fed51035c13418f87b9/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/d9cff176581d901a8b2b1fed51035c13418f87b9/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc
[add] https://crrev.com/d9cff176581d901a8b2b1fed51035c13418f87b9/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.h
[add] https://crrev.com/d9cff176581d901a8b2b1fed51035c13418f87b9/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
[add] https://crrev.com/d9cff176581d901a8b2b1fed51035c13418f87b9/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.h
[add] https://crrev.com/d9cff176581d901a8b2b1fed51035c13418f87b9/chrome/browser/android/vr_shell/textures/ui_texture.cc
[add] https://crrev.com/d9cff176581d901a8b2b1fed51035c13418f87b9/chrome/browser/android/vr_shell/textures/ui_texture.h
[modify] https://crrev.com/d9cff176581d901a8b2b1fed51035c13418f87b9/ui/gfx/BUILD.gn

Comment 5 by acondor@google.com, Apr 20 2017

Blockedon: 713779
Blockedon: 713938
Owner: mthiesse@chromium.org
Bouncing this over to mthiesse@ as acondor@ and mthiesse@ are doing the work.
Status: Fixed (was: Started)
Marking as fixed - outstanding improvements are covered in other bugs.

Sign in to add a comment