New issue
Advanced search Search tips

Issue 710144 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

valgrind doesn't build for boards with kernel 4.4

Project Member Reported by norvez@chromium.org, Apr 10 2017

Issue description


./configure checks the kernel version and fails for kernel >= 4.0.

There's an upstream fix: https://github.com/svn2github/valgrind/commit/bf803555d10b5b4c9223b24bf13845ee88d8f3b5

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/d32b2529b55502f0c24a05999e4833e9b0aa90d3

commit d32b2529b55502f0c24a05999e4833e9b0aa90d3
Author: Nicolas Norvez <norvez@chromium.org>
Date: Wed Apr 12 03:22:35 2017

dev-util/valgrind: upgrade to 3.10.1

Upgrade to 3.10.1, needed specifically so valgrind compiles for boards
with kernel 4.4.

Compared to upstream, this CL includes:
- patch for glibc version 2.23 introduced by CL:428331 instead of
patches for glibc 2.21 and 2.22
- modifies ebuild to use  KEYWORD="*"

Cleanup:
The CL also deletes unused non-exec-stack patch against 3.9.0.

BUG= chromium:710144 
TEST=emerge-eve valgrind
TEST=emerge-kevin valgrind
TEST=emerge-{amd64,arm}-generic valgrind
TEST=emerge-x86-generic valgrind fails (clang-syntax, will file bug) but
3.10.0-r1 is not building either anyway.
TEST='valgrind ls' on eve

Change-Id: I310051ee8d005b50416a9c48a366de115f4a015f
Reviewed-on: https://chromium-review.googlesource.com/470006
Commit-Ready: Nicolas Norvez <norvez@chromium.org>
Tested-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/eab2436449ff07fe57576a65a5afbd11d0a0d74a/dev-util/valgrind/files/valgrind-3.9.0-non-exec-stack.patch
[modify] https://crrev.com/d32b2529b55502f0c24a05999e4833e9b0aa90d3/dev-util/valgrind/metadata.xml
[rename] https://crrev.com/d32b2529b55502f0c24a05999e4833e9b0aa90d3/dev-util/valgrind/valgrind-3.10.1.ebuild
[rename] https://crrev.com/d32b2529b55502f0c24a05999e4833e9b0aa90d3/dev-util/valgrind/files/valgrind-3.10.1-non-exec-stack.patch
[modify] https://crrev.com/d32b2529b55502f0c24a05999e4833e9b0aa90d3/dev-util/valgrind/Manifest
[add] https://crrev.com/d32b2529b55502f0c24a05999e4833e9b0aa90d3/dev-util/valgrind/files/valgrind-3.10.1-linux-4.patch

Comment 2 by norvez@chromium.org, Apr 12 2017

Status: Fixed (was: Started)

Comment 3 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment