[WebPayments] Segfault when canceling payment if validation errors present |
||||
Issue description1. Open a PaymentRequest dialog 2. Go to an editor (Add a Credit Card, Add a Shipping Address, etc.) 3. Focus and blur a required field so that a validation error appears 4. Click the Cancel button to exit PaymentRequest 5. Surprise! Segfault! This happens at least on Mac but probably on other Desktop platforms as well.
,
Apr 10 2017
I'm happy to! It might be a few days though, so anyone else is welcome in the meantime if they have bandwidth.
,
Apr 12 2017
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49 commit 457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49 Author: mathp <mathp@chromium.org> Date: Wed Apr 12 15:14:55 2017 [Payments] Change how the dialog gets destroyed. The views need to go first, then the controllers. This is because some views may have pointers/delegates back to their controllers. BUG= 710127 TEST=a few more browser_tests Review-Url: https://codereview.chromium.org/2810193003 Cr-Commit-Position: refs/heads/master@{#464026} [modify] https://crrev.com/457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc [modify] https://crrev.com/457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49/chrome/browser/ui/views/payments/payment_request_browsertest.cc [modify] https://crrev.com/457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49/chrome/browser/ui/views/payments/payment_request_dialog_view.h [modify] https://crrev.com/457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49/chrome/browser/ui/views/payments/view_stack.h
,
Apr 12 2017
,
Jun 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rouslan@chromium.org
, Apr 10 2017Status: Assigned (was: Untriaged)