New issue
Advanced search Search tips

Issue 710124 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

PreCQ launcher confused by CQ-DEPENDs between different kernel branches.

Project Member Reported by dgarr...@chromium.org, Apr 10 2017

Issue description

Change A:
  https://chromium-review.googlesource.com/#/c/470867/

Has a CQ dependency on change B:
  https://chromium-review.googlesource.com/#/c/470926/

Change B is in a kernel repository, on branch "chromeos-3.14", while chnage A is in chromite on TOT.

Both changes were made on a clean TOT manifest checkout, but when putting the changes through the PreCQ, the PreCQ launcher gives errors because they are not on the same branch.

"""
The Pre-Commit Queue failed to apply your change in https://luci-milo.appspot.com/buildbot/chromeos/pre-cq-launcher/8978 . CL:470867 depends on CL:470926, which was not eligible (wrong manifest branch, wrong labels, or otherwise filtered from eligible set).
"""

I've verified that labels were set incorrectly. I suspect the git repository branch name is what is confusing things, even though the "manifest branch" listed in the error is the same.

 
Owner: akes...@chromium.org
This has probably been causing occasional confusion and pain for a while, so we should find an owner.

Cc: nxia@chromium.org akes...@chromium.org
Labels: Hotlist-Fixit
Owner: ----
Status: Available (was: Untriaged)
Summary: PreCQ launcher confused by CQ-DEPENDs between different kernel branches. (was: PreCQ launcher confused by kernel branches.)
Good fixit candidate.

Comment 3 by aut...@google.com, Apr 18 2017

Labels: -current-issue
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS

Comment 6 by nxia@chromium.org, Jun 8 2018

Cc: -nxia@chromium.org
Labels: Hotlist-GoodFirstBug
Owner: jclinton@chromium.org
Why would we ever have CQ-DEPEND between two independent kernel branches? Maybe this is causing the PreCQ launcher to crash?

Will have Evan take a look at this when he starts.

Status: Assigned (was: Available)

Sign in to add a comment