Light status bar icons on light background |
||
Issue descriptionThe ability to theme the status bar is available in android L (api 21) while the ability to make the icons dark is available in android M (api 23). Chrome Home almost always uses a light status bar which makes the icons hard to see on android L. Should the status bar be left black for anything below android M?
,
Apr 10 2017
,
Apr 10 2017
Yeah, let's keep the status bar black on <M.
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54c4473401a83a2e700d39cf3ee0fee91eb198fc commit 54c4473401a83a2e700d39cf3ee0fee91eb198fc Author: mdjones <mdjones@chromium.org> Date: Tue Apr 11 21:49:15 2017 [Home] Fix coloring issues in status bar This change fixes two problems: - The Android api levels that allow changing of the status bar background and the level that allows status bar "light mode" for the icons is different. Any version of Android below M will now use black as the status bar color if Chrome Home is enabled. - The system UI flag indicating whether or not the status bar was in "light mode" was never reset when viewing the tab switcher or incognito NTP. This change removes the flag in those cases. All the status bar color logic now lives in BottomSheet.java, making ChromeTabbedActivity easier to read. BUG= 710084 , 708680 Review-Url: https://codereview.chromium.org/2809003006 Cr-Commit-Position: refs/heads/master@{#463785} [modify] https://crrev.com/54c4473401a83a2e700d39cf3ee0fee91eb198fc/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/54c4473401a83a2e700d39cf3ee0fee91eb198fc/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
,
Apr 18 2017
Issue 711393 has been merged into this issue.
,
Apr 29 2017
yes this is an issue in Android 6.0 too, I put a red box around the 2 things that are an issue in attached screenshot. It's probably best to stick with the black bar/white icons for Android 6.0
,
Jun 14 2017
This should be fixed by our change to use light on dark text/icons again. |
||
►
Sign in to add a comment |
||
Comment 1 by cl...@chromium.org
, Apr 10 2017