New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710078 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature



Sign in to add a comment

Display Browser Actions context menu dialog with the help of Chrome context menu API

Reported by ltian@chromium.org, Apr 10 2017

Issue description

Display a Browser Actions context menu dialog using the Chrome context menu API. This requires refactoring Chrome context menu to allow custom items with strings and icons sent from Browser Action intent. 



 

Comment 1 by ltian@chromium.org, Apr 10 2017

Components: UI>Browser>Mobile>CustomTabs
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc5ed1f9afe1fee37119450781651e2fbae29f6c

commit fc5ed1f9afe1fee37119450781651e2fbae29f6c
Author: ltian <ltian@chromium.org>
Date: Fri May 19 07:57:25 2017

[Android] Show Browser Actions dialog in Chrome

Display Browser Actions dialog by refactoring Chrome context menu code. Add
ContextMenuItemGetter interface to provide the capability to custom menu
title and icon. Also add BrowserActionsContextMenuPopulator to match the
menu id with custom behavior.

BUG= 710078 

Review-Url: https://codereview.chromium.org/2815453002
Cr-Commit-Position: refs/heads/master@{#473124}

[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/res/values/ids.xml
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
[add] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuHelper.java
[add] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java
[add] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsCustomContextMenuItem.java
[add] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItem.java
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/java_sources.gni
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java
[modify] https://crrev.com/fc5ed1f9afe1fee37119450781651e2fbae29f6c/chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java

Comment 3 by ltian@chromium.org, Jun 7 2017

Status: Fixed (was: Assigned)

Sign in to add a comment