New issue
Advanced search Search tips

Issue 710074 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

sys-apps/busybox: upgrade to latest upstream version

Project Member Reported by vapier@chromium.org, Apr 10 2017

Issue description

would be good to get 1.26.2 or newer
 
1.26.x still marked unstable in upstream Gentoo: https://packages.gentoo.org/packages/sys-apps/busybox.

1.25.x has fixes for 2 CVE's, though, so I'm going to do that: http://www.cvedetails.com/vulnerability-list/vendor_id-4282/product_id-7452/year-2017/Busybox-Busybox.html

Owner: jclinton@chromium.org
Status: Started (was: Available)
Actually, I can't find a bug in Gentoo's tracker explaining why it's been held out of stable for so long. I'll send 1.26.2 through the trybots and deploy to a physical machine and see how that goes.
Flashed test build to Peppy, tested ssh, tested chromeos-install, verified busybox version.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f

commit 33a875fc251ce6fb7202d44ecc0be3fe5d2b410f
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Sat Apr 15 20:10:49 2017

busybox: upgraded package to upstream

Upgraded sys-apps/busybox to version 1.26.2 on amd64, arm, x86

BUG= chromium:710074 
TEST=for b in peppy daisy x86-generic; do
  FEATURES=test emerge-$b -q --nodeps busybox; done
Also submitted to trybots:
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/pre_cq/builds/27844
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/10514
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/10513
Also built and flashed to Peppy and tested various devel features/flashing/ssh.

Change-Id: I68fbd68f2e82875acb78ac5ea504a8583fc3d85d
Reviewed-on: https://chromium-review.googlesource.com/477614
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/files/klogd.initd
[add] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/files/mdev.initd
[delete] https://crrev.com/a5308b8c19cf9035337a19fe35864f174167a6a5/sys-apps/busybox/files/busybox-1.23.1-modprobe-small.patch
[delete] https://crrev.com/a5308b8c19cf9035337a19fe35864f174167a6a5/sys-apps/busybox/files/busybox-1.23.1-trylink-flags.patch
[rename] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/busybox-1.26.2.ebuild
[modify] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/files/ntpd.initd
[add] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/files/busybox-1.26.2-bb.patch
[delete] https://crrev.com/a5308b8c19cf9035337a19fe35864f174167a6a5/sys-apps/busybox/files/mdev.rc.1
[add] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/metadata/md5-cache/sys-apps/busybox-1.26.2
[modify] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/files/syslogd.initd
[delete] https://crrev.com/a5308b8c19cf9035337a19fe35864f174167a6a5/metadata/md5-cache/sys-apps/busybox-1.23.1-r1
[modify] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/files/mdev/usbdisk_link
[modify] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/files/ginit.c
[modify] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/files/watchdog.initd
[modify] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/Manifest
[modify] https://crrev.com/33a875fc251ce6fb7202d44ecc0be3fe5d2b410f/sys-apps/busybox/metadata.xml
[delete] https://crrev.com/a5308b8c19cf9035337a19fe35864f174167a6a5/sys-apps/busybox/files/busybox-1.19.0-bb.patch

Status: Fixed (was: Started)

Comment 8 by djkurtz@google.com, Apr 18 2017

Status: Assigned (was: Fixed)
I this change broke recovery images.  See  issue 712564 .
It seems we don't have tests on recovery images. This looks like busybox symlinks are broken in recovery which even a simple boot test should have found. I'm manually building and deploying recovery image now. Will also need to figure out how to get a serial console.

From https://bugs.chromium.org/p/chromium/issues/detail?id=712564:

Commenting out "exec >"${LOG_FILE}" 2>&1" in initramfs/recovery/init keeps all recovery output directed at stdout/stderr.
This shows the actual errors are related to unexecutable shell functions:

+ initialize
+ init_check_clock
+ date +%Y
sh: can't execute 'date': No such file or directory
+ [ -lt 1970 ]
sh: 1970: unknown operand
+ init_mounts
+ mount -n -t proc -o nodev,noexec,nosuid proc /proc
sh: can't execute 'mount': No such file or directory
+ mount -n -t sysfs -o nodev,noexec,nosuid sysfs /sys
sh: can't execute 'mount': No such file or directory
+ mount -t devtmpfs -o mode=0755,nosuid devtmpfs /dev
sh: can't execute 'mount': No such file or directory


... yeah, they are all busybox functions: [date, mount, sed, tail, tee, ...]

After much spelunking--crawling through places keep in the earth forgot even by mythical creatures--I've figured out how to reproduce this relatively rapidly. Indeed, all of the busybox symlinks are missing. Going to focus on finding a root cause, now.
Cc: teravest@chromium.org sjg@chromium.org
It took a lot of serial console debugging to figure this this out. There were three root causes:

1. BusyBox 1.23 in Portage is configured to force static compilation by default "+static". 1.26 switch this to optional+off-by-default. The pending upgrade to 1.26 will enable static again.

2. We compile BusyBox statically without installing symlinks in the initramfs. When doing so, in BusyBox >=1.26, it attempts to use an execve of busybox to satisfy shell script references to busybox applets.  This only works if it can find its own binary path through examination of /proc/self/exe. The mount of the /proc filesystem would therefore fail if we invoked a naked "mount". To work around this,  we can invoke the actual busybox binary in the $PATH and then, subsequently, all built-ins will work. See: https://git.busybox.net/busybox/tree/shell/ash.c?h=1_26_2#n7606 . Work-around for this in: https://chromium-review.googlesource.com/c/484709 .

3. There is no way to test our Recovery images, at all. So, this wasn't caught until someone went to install a Recovery image.

I will probably also write a doc on serial-console debugging Recovery because that--alone--took 3 days to get working.

Cc: vapier@chromium.org
the initramfs/ subdir has some logic for testing.  check out README.md and test/README.md.  there is also discussion in general about test coverage missing on recovery images in the CQ as you're not the only one to run into this.
test/test.sh is broken at head. I've opened https://bugs.chromium.org/p/chromium/issues/detail?id=714774 for that. On the plus side, it's a faster version of what I was doing: building and deploying to hardware so I can continue to do that, for now.
I have a fix that's pending two CL's making it through code review and CQ that's broken right now.

Meanwhile, I've created a tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=715162 for how difficult debugging Recovery is. For now, I have a doc that describes how to hack something together for debugging: https://docs.google.com/document/d/1DTN-s0TwD-G1kjD66HQFnvQvuc1fT1Yvr3ScUCGB940/edit .

instead of a Google doc, how about updating the README.md files in the initramfs dirs ?
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8

commit 24b5574ca033f6cd1def84d17e43a3fa4c27e9c8
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Tue Apr 25 21:03:49 2017

busybox: Add masked, pristine copy of 1.26.2 ebuild from upstream

This is in preparation for setting "+static" on the ebuild. Upstream had
previously set "+static" which we rely on for our Recovery images.
Now, upstream doesn't set this (though it remains an optional USE flag).
In a follow-up commit, I will set our overlay to "+static" and unmask
this package to finish the upgrade without breaking Recovery.

I followed the instructions at:
http://www.chromium.org/chromium-os/gentoo-package-upgrade-process#TOC-Re-applying-a-patch-after-upgrade

BUG= chromium:710074 
TEST=Ran equery + build_packages to confirm that 1.23.1 is still used.

Change-Id: If7864140dcd17be5c38c5bc14f09915f72ba267a
Reviewed-on: https://chromium-review.googlesource.com/485861
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/klogd.initd
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/watchdog.confd
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/klogd.confd
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/watchdog.initd
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/busybox-1.26.2.ebuild
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/profiles/default/linux/package.mask/busybox
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/ntpd.initd
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/syslogd.confd
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/mdev/dvbdev
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/busybox-1.26.2-bb.patch
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/mdev.initd
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/mdev/ide_links
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/syslogd.initd
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/ntpd.confd
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/metadata.xml
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/mdev/usbdisk_link
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/ginit.c
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/Manifest
[add] https://crrev.com/24b5574ca033f6cd1def84d17e43a3fa4c27e9c8/sys-apps/busybox/files/mdev/usbdev

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 26 2017

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7127dc4788d798e6c6bc6c774866429f722e2fab

commit 7127dc4788d798e6c6bc6c774866429f722e2fab
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Fri Apr 28 03:28:43 2017

beaglebone: Fix global override to USE pam which collides with static

This is blocking the upgrade of BusyBox to 1.26.2:
https://uberchromegw.corp.google.com/i/chromeos/builders/beaglebone-paladin/builds/13189/steps/BuildPackages/logs/stdio

BusyBox 1.26.2 ebuild switches from "+static" to "static".

BUG= chromium:710074 
TEST=built beaglebone locally to confirm that this works
Change-Id: I0533f895bdbbf95a8c79a3abb9459bcd2e8c5d57
Reviewed-on: https://chromium-review.googlesource.com/489668
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7127dc4788d798e6c6bc6c774866429f722e2fab/overlay-beaglebone/profiles/base/package.use

Project Member

Comment 19 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e7426a0951b3af3174499f00b41b10ff76ebd657

commit e7426a0951b3af3174499f00b41b10ff76ebd657
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Fri Apr 28 10:03:28 2017

Revert "busybox: Add masked, pristine copy of 1.26.2 ebuild from upstream"

This reverts commit 24b5574ca033f6cd1def84d17e43a3fa4c27e9c8.

It also adds a default USE of static in preparation for upgrading to
pristine 1.26.2 from Portage upstream. In 1.26.2, the default "+static"
is no longer set (which we were relying on).

BUG= chromium:710074 
TEST=emerged busybox on 2 platforms; confirmed it's still 1.23 + static
CQ-DEPEND=CL:489668

Change-Id: I0b67bfb32dd4d76de94bdb7eeed30c3462a0fb2b
Reviewed-on: https://chromium-review.googlesource.com/488921
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/klogd.initd
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/watchdog.confd
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/klogd.confd
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/watchdog.initd
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/busybox-1.26.2.ebuild
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/profiles/default/linux/package.mask/busybox
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/ntpd.initd
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/syslogd.confd
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/mdev/dvbdev
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/busybox-1.26.2-bb.patch
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/mdev.initd
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/mdev/ide_links
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/syslogd.initd
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/ntpd.confd
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/metadata.xml
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/mdev/usbdisk_link
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/ginit.c
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/Manifest
[delete] https://crrev.com/00c8a4c2b2a005be037f977cd2e736333bac6944/sys-apps/busybox/files/mdev/usbdev
[modify] https://crrev.com/e7426a0951b3af3174499f00b41b10ff76ebd657/profiles/targets/chromeos/package.use

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f

commit c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Fri Apr 28 21:16:12 2017

busybox: upgraded package to upstream

Upgraded sys-apps/busybox to version 1.26.2 on amd64, arm, x86

BUG= chromium:710074 
TEST=built and deployed Recovery image to hardware (Pyro);
updated dependent CL to depend on fix, rebuilt beaglebone board with
all 3 CL's
CQ-DEPEND=CL:488921

Change-Id: I0265b82381147dd39857697b0950a5dd8050eae6
Reviewed-on: https://chromium-review.googlesource.com/489122
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/files/klogd.initd
[delete] https://crrev.com/b6edc6fe3f0074c4d1dd4216ffe3389932dc402c/sys-apps/busybox/files/busybox-1.23.1-modprobe-small.patch
[modify] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/files/watchdog.initd
[add] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/files/mdev.initd
[modify] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/files/ntpd.initd
[add] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/metadata/md5-cache/sys-apps/busybox-1.26.2-r1
[add] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/files/busybox-1.26.2-bb.patch
[delete] https://crrev.com/b6edc6fe3f0074c4d1dd4216ffe3389932dc402c/sys-apps/busybox/files/mdev.rc.1
[delete] https://crrev.com/b6edc6fe3f0074c4d1dd4216ffe3389932dc402c/sys-apps/busybox/files/busybox-1.23.1-trylink-flags.patch
[modify] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/files/syslogd.initd
[delete] https://crrev.com/b6edc6fe3f0074c4d1dd4216ffe3389932dc402c/metadata/md5-cache/sys-apps/busybox-1.23.1-r1
[modify] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/files/mdev/usbdisk_link
[modify] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/files/ginit.c
[rename] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/busybox-1.26.2-r1.ebuild
[modify] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/Manifest
[modify] https://crrev.com/c7ba763783cf2cb9ffca9d5d929fed2f4c23c49f/sys-apps/busybox/metadata.xml

Project Member

Comment 22 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/bd02c71d54e9aa94adc870e1d518234a67142689

commit bd02c71d54e9aa94adc870e1d518234a67142689
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Wed May 10 03:36:33 2017

Fix Markdown syntax errors and ran the file through mdformat

BUG= chromium:710074 
TEST=none needed

Change-Id: I2f5ecabf731fb69e62e80d6e7f9d87bcaf9964d8
Reviewed-on: https://chromium-review.googlesource.com/500988
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/bd02c71d54e9aa94adc870e1d518234a67142689/recovery/README.md

Project Member

Comment 23 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/5ae7c8ac19c53034208dcb8e28011b61263bdadc

commit 5ae7c8ac19c53034208dcb8e28011b61263bdadc
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Wed May 10 03:36:33 2017

Add Recovery serial console debugging instructions

BUG= chromium:710074 
TEST=none needed

Change-Id: Ieb3d213a9604606dd0510938070de0495f88f9ff
Reviewed-on: https://chromium-review.googlesource.com/500989
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/5ae7c8ac19c53034208dcb8e28011b61263bdadc/recovery/README.md

Comment 24 by sjg@google.com, Jul 5 2017

Labels: Team-BLD
Labels: VerifyIn-61
Project Member

Comment 26 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d27a1a52bb7b7c063f40532b419887237719df49

commit d27a1a52bb7b7c063f40532b419887237719df49
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Sep 15 17:50:32 2017

busybox: turn off static linking

We turned this on because it was historically enabled, and because
there was a latent bug in the hush wrapper patch.  Those should be
fixed by the upstream Gentoo 5c7ecf36f0bbbe18b513d7afb82b0f7bf3428
(which we included in CL:489122), so we can drop this again.

BUG= chromium:712564 , chromium:710074 , chromium:764753 
TEST=precq passes
TEST=recovery image still works

Change-Id: Ia8de426f7da212ef2970340adfca691d9ebfc553
Reviewed-on: https://chromium-review.googlesource.com/668036
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/d27a1a52bb7b7c063f40532b419887237719df49/profiles/targets/chromeos/package.use

Comment 27 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment