tab mirroring broken. local content flashes white and blue when page updates |
|||||
Issue descriptionChrome Version: 59.0.0367.0 OS: Any What steps will reproduce the problem? (1) Mirror a tab (2) move mouse or play video What is the expected result? content on sender is not affected. Looks normal. What happens instead? content on sender turns blue or white in large block sections and flickers intensely. *Recent regression. Does not occur in current dev version 59.0.3063.4 Note that content on the receiver is unaffected.
,
Apr 10 2017
I just did a bisect of official Chrome builds. The first known bad version is 59.0.3064.0. The previous version 59.0.3063.4 is good.
,
Apr 11 2017
I was able to do a Chromium bisect, here are the results: You are probably looking for a change made after 462211 (known good), but no later than 462215 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/8c16f40605e9b9608ed338606c60c564232211ad..bb0b3ae9224e1883dd491b6b6810b6bfe0da8480
,
Apr 11 2017
This is the culprit: https://chromium.googlesource.com/chromium/src/+/bb0b3ae9224e1883dd491b6b6810b6bfe0da8480 Uploaded a revert CL for reviewing: https://codereview.chromium.org/2811013002/
,
Apr 11 2017
,
Apr 11 2017
I believe this is also caused by the problem this CL tries to fix: https://codereview.chromium.org/2804953008/. I'll land the patch right away.
,
Apr 11 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ab7d98f69b14b75c21925564b099792ac13c2aa commit 1ab7d98f69b14b75c21925564b099792ac13c2aa Author: sunxd <sunxd@chromium.org> Date: Tue Apr 11 01:58:50 2017 cc: Make surface aggregator convert surface quad to RPDQ correctly SurfaceAggregator used to arbitrarily set a place holder for tex_coord_rect when converting surface quad to RPDQ. This results in not applying any texture when effects are applied to the whole surface. This patch corrects the value to be surface_quad->rect. BUG= 709369, 710040 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2804953008 Cr-Commit-Position: refs/heads/master@{#463495} [modify] https://crrev.com/1ab7d98f69b14b75c21925564b099792ac13c2aa/cc/surfaces/surface_aggregator.cc
,
Apr 11 2017
,
Apr 11 2017
,
Apr 12 2017
Does this bug also explain why we get strange resolutions (very high) from tab capture on 59?
,
Apr 12 2017
niklase@: The issue with high resolutions was caused by the new constraints algorithm and should be fixed by https://codereview.chromium.org/2800343005/ Note also that the default resolution for screen capture was updated from 640x480 to 2880x1800 as per your suggestion on issue 257097 .
,
Apr 12 2017
I'm not very familiar with tab mirroring and capture, but my guess is not: cc renders all elements on a surface, and surface aggregator converts the surface into a single quad (like doing a snapshot). The bug failed to report the correct rect bounds of the converted quad (it reports an empty quad), so renderer displays nothing for the mirrored tabs. But I don't think it can explain a high resolution.
,
Apr 12 2017
#12 explains it, I just happened to see both problems come and go at the same time.
,
Apr 18 2017
,
Apr 18 2017
Verified the fix on Windows 7/10, mac and Linux with Chrome version 59.0.3071.9. Steps Followed : 1. Install and launch Chrome 2. Create a hangout invite and join the meeting 3. Present a tab(Screenshare) 4. Move mouse around and observe. Observed behavior : There is no flickering or turn white after 5 to 10min mouse moves. Note : When we present the tab with video chat I see multiple screens getting created. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by m...@chromium.org
, Apr 10 2017Status: Assigned (was: Untriaged)