New Android Compile bots don't have resource sizes |
||||||||||||
Issue descriptionThe Android and Android arm64 builders: - https://build.chromium.org/p/chromium.perf/builders/Android%20Builder - https://build.chromium.org/p/chromium.perf/builders/Android%20arm64%20Builder have been failing for a while now on the trigger step (e.g. https://build.chromium.org/p/chromium.perf/builders/Android%20Builder/builds/153153) The builds finish successfully and still report resource_sizes metrics, but it's odd that this step is failing.
,
Apr 10 2017
These builders aren't doing anything anymore. The Android Compile builders are what is driving the android bots now. I need to remove them, but that requires a master restart, which breaks current builds.
,
Apr 10 2017
Issue 709552 has been merged into this issue.
,
Apr 10 2017
We're getting rid of these builders? Unless I'm misunderstanding something, we use them for all of our binary-size dashboards that use resource_sizes.py (ex. https://chromeperf.appspot.com/report?sid=5d55db44beb13bb1e813882381fe82b47aa2934496f2e59840f8ee908da122ca&num_points=1500).
,
Apr 10 2017
We're replacing them with equivalent builders, which are live now (example is https://build.chromium.org/p/chromium.perf/builders/Android%20Compile/builds/35056). Looks like they don't actually have resource sizes on them, which is bad, and a bug. I'll fix that.
,
Apr 10 2017
:( We have a lot of links to resource_sizes graphs on these bots. I'm guessing they will all now have to be recreated? If there's a way to transition the graphs over, please advice (~ 30 min worth of dragging & dropping graphs involved to recreate them). Or maybe we could have the new builds take the same name as the old builders?
,
Apr 10 2017
,
Apr 10 2017
To be clear, the bots aren't triggering, but are still running resource sizes. So nothing is actually broken right now. re #6: What do you mean lots of links? Can you share one, and where they come from?
,
Apr 10 2017
It's possible to change the builder names to be the same as the old ones. I'd prefer not to, since "Android Builder" being a builder is really confusing, because builder is an overloaded term. But we can.
,
Apr 10 2017
All dashboards linked-to from here: go/chrome-apk-size would need to be recreated (not a big deal if unavoidable). More importantly though, I'm wondering if the dashboards would retain past data if we used the same name? Ex. this one: https://chromeperf.appspot.com/report?sid=5d55db44beb13bb1e813882381fe82b47aa2934496f2e59840f8ee908da122ca&num_points=1500. If that's the case then it would be great if we could use the same builder names since it's useful to be able to compare longer term changes in binary size.
,
Apr 10 2017
Adding more speed ops people. I agree that keeping the metric history on the perf dashboard is a good idea.
,
Apr 10 2017
We have two options: 1) If we retain the old names, the data will show up on the same charts. 2) If we pick a new name, we can migrate the old data, but it could take a week or two.
,
Apr 10 2017
How does the name get picked? Or generated? On the perfdashboard, the name is "Android Builder". Is that set by the buildername of the build? I'm not sure where it comes from :/
,
Apr 10 2017
+dtu who added resource sizes to the builders: Dave, do you know where the perf dashboard name "Android Builder" comes from?
,
Apr 10 2017
,
Apr 10 2017
Hmhh, if we are using the new bot ("Android Compile"), I think it worths using the new name so people don't confuse whether the data come from. Can we just migrate the old data in the last 1 month, would the migration process be faster?
,
Apr 10 2017
I didn't do resource_sizes. I added sizes for the desktop bots only. Those use os_name and os_name-32. I.e. linux, mac, win, win-32. To be consistent, we should use android and android-32. Looks like resource_sizes just has that perf_id because no one updated it. The recipe calls `api.chromium_android.resource_sizes()` with no perf_id parameter, and the default is the builder name. https://codereview.chromium.org/2306853003 https://codereview.chromium.org/1560243002
,
Apr 10 2017
So, I think it'd be better to change it to maybe just "Android", and then migrate some data. It's clearer then, and less tied to our builder names.
,
Apr 11 2017
I'd say that the Android names should also include the architecture (rather than just the number of bits).
,
Apr 12 2017
Yes, that makes sense. I'll add resource sizes to the chromium compile bots.
,
Apr 12 2017
Thanks! Regarding c#12: with the rename it would be great if we could migrate the old data to the new compile bots - anything we need to do to kick this off?
,
Apr 12 2017
I agree with #21. Annie, how would we migrate the old data? I'm writing a CL to start running the resource sizes; is there anything I need to do to to make this migration work? Should I be waiting for anything?
,
Apr 12 2017
#22: there is no pre-step for data migration. Once you make resource sizes on new bot working, you can file another bug to the speed-service team to have them migrate the data over.
,
Apr 13 2017
Yep, what Ned said. You can use the "report issue" menu in the dashboard to request a data migration when the old data stops coming in.
,
Apr 14 2017
I chatted with jbudorick@ offline. We came to the decision that we should move the logic which is currently in the android/builder and chromium_android recipes source side, and add an entry to the source side json, to run the resource sizes script. This should be feasible; the only part that's questionable is how we make the chromium recipe run this on a builder, but I can handle that. rnephew@, could you possibly look at writing this script? It would replace the logic encapsulated here: https://cs.chromium.org/chromium/build/scripts/slave/recipes/android/builder.py?q=android/builder+package:%5Echromium$&l=256
,
May 2 2017
Note: we'll also need this bot to run "supersize archive" wherever it runs resource_sizes.py. Added to Android Builder here: https://chromium-review.googlesource.com/c/491986/
,
May 26 2017
,
Jun 8 2017
History is very important because we can then do things like this: http://docs/spreadsheets/d/1KDZ2E9rhrcP9ppcaM5qL3gM3iMRAvKxKEbN2x-Iar4g/edit#gid=139785849 Thanks!
,
Dec 4 2017
Moving Infra>Client>Android -> Infra>Client>Chrome+OS=Android
,
Dec 4 2017
,
Aug 2
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by jbudorick@chromium.org
, Apr 10 2017Status: Assigned (was: Untriaged)