If the merchant doesn't support a specific shipping address (i.e. returns no valid shipping option for a given address), the UI should display an error.
Attaching proposed solution
This looks great!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb8892ff597ac955e4eebe688a57ca0b81b02bd4 commit eb8892ff597ac955e4eebe688a57ca0b81b02bd4 Author: mathp <mathp@chromium.org> Date: Thu May 04 18:42:55 2017 [Payments] Display the shipping option error alongside the address In the Payment Sheet and the Address selector, display the shipping option error. BUG= 710004 TEST=browser_tests Review-Url: https://codereview.chromium.org/2855203002 Cr-Commit-Position: refs/heads/master@{#469397} [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_method_view_controller.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_request_item_list.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_request_item_list.h [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_request_item_list_unittest.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_request_views_util.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/profile_list_view_controller.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/profile_list_view_controller.h [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/shipping_option_view_controller.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/chrome/test/data/payments/dynamic_shipping.js [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/components/payments/content/BUILD.gn [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/components/payments/content/payment_request_spec.cc [modify] https://crrev.com/eb8892ff597ac955e4eebe688a57ca0b81b02bd4/components/payments/content/payment_request_spec.h
Comment 1 by erikc...@chromium.org
, Apr 24 2017