Payment Request should show error in console for bad icon request
Reported by
matt.t.g...@gmail.com,
Apr 10 2017
|
||||
Issue descriptionSteps to reproduce the problem: 1. On Chrome for Android, open devtools for the current tab 2. Go to https://output.jsbin.com/hulifeqota/quiet/ What is the expected behavior? An error be displayed in the DevTools console saying the request for "nopenopenope.ico" failed / 404'd. (This is due to the favicon being: <link rel="shortcut icon" href="nopenopenope.ico">) What went wrong? Nothing is printed and instead no favicon is shown in the UI, just an empty space. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 57.0.2987.133 Channel: stable OS Version: Flash Version:
,
Apr 13 2017
,
May 8 2017
Matt: How about this warning message? "Favicon not found for PaymentRequest UI. User may not recognize the website."
,
May 8 2017
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b040be30ba61d2589511f2225a99d1dafeb46da commit 4b040be30ba61d2589511f2225a99d1dafeb46da Author: rouslan <rouslan@chromium.org> Date: Thu May 18 22:37:48 2017 Warn web developer on missing favicon for PaymentRequest UI. Before this patch, a missing favicon would result in a blank space on PaymentRequest UI on Android and no indication to the web developer that something went wrong. This patch adds a Mojo method PaymentRequestClient.WarnNoFavicon(), which is invoked by the browser and implemented in the renderer. The browser invokes the method when it finds no favicon and thus leaves a blank space on UI. The renderer implementation prints a warning in DevTools: "Favicon not found for PaymentRequest UI. User may not recognize the website." After this patch, a missing favicon on a page that's using PaymentRequest on Android results in a DevTools warning for the web developer. BUG= 710002 Review-Url: https://codereview.chromium.org/2869893002 Cr-Commit-Position: refs/heads/master@{#472954} [modify] https://crrev.com/4b040be30ba61d2589511f2225a99d1dafeb46da/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/4b040be30ba61d2589511f2225a99d1dafeb46da/components/payments/mojom/payment_request.mojom [modify] https://crrev.com/4b040be30ba61d2589511f2225a99d1dafeb46da/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/4b040be30ba61d2589511f2225a99d1dafeb46da/third_party/WebKit/Source/modules/payments/PaymentRequest.h
,
Jun 8 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by krav...@chromium.org
, Apr 12 2017Status: Available (was: Unconfirmed)