New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709988 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Fix WebRTC tests running on Swarming but not implementing --isolated-script-test-output flag.

Project Member Reported by kjellander@chromium.org, Apr 10 2017

Issue description

I had to revert https://chromium-review.googlesource.com/c/472290/ today after breaking our tree. It's because we have two tests that aren't using https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/gtest-parallel-wrapper.py, which means when the recipe code passes --isolated-script-test-output to the tests and no JSON is output, the test counts as a failure.
 
The fact this isn't already failing is a pretty big issue! It means we are not failing when a script returns empty JSON like we should.
Cc: tansell@chromium.org
I haven't had time to dig into the details, but it has worked as intended for us so far.
The tests in question for WebRTC are: low_bandwidth_audio test and webrtc_nonparallel_tests.

Example failure of webrtc_nonparallel_tests: 
https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug/builds/12458

Status: Fixed (was: Assigned)
This was fixed by https://codereview.webrtc.org/2806373002/ (I forgot to add the chromium: prefix in the BUG= entry).

Sign in to add a comment