New issue
Advanced search Search tips

Issue 709987 link

Starred by 3 users
Status: Fixed
Owner:
dcheng@chromium.org
Closed: Apr 2017
Cc:
danakj@chromium.org
lukasza@chromium.org
dcheng@chromium.org
thakis@chromium.org
e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 675877



Sign in to add a comment

Blink rename bug: FrameView::layout -> FrameView::GetLayout

Project Member Reported by bokan@chromium.org, Apr 10 2017 
Not sure if bugs are how we're tracking/fixing these but it looks like the rename incorrectly renamed FrameView::layout to FrameView::GetLayout, which is clearly wrong as it has no return value.

Comment 1 by dcheng@chromium.org, Apr 10 2017

Blocking: 675877
Cc: danakj@chromium.org lukasza@chromium.org

Comment 2 by e...@chromium.org, Apr 10 2017

Cc: e...@chromium.org

Comment 3 by dtapu...@chromium.org, Apr 10 2017

Components: -Blink Blink>Internals

Comment 4 by lukasza@chromium.org, Apr 10 2017 

"layout" is from the original hardcoded list of things (r439818) that need a "Get" prefix :-(.  Hopefully no other method names are similarily broken, but we might want to look out for other names where "Get" prefix might not be appropriate (e.g. names that might be used both as a noun and as a verb).  FWIW, the hardcoded list is at https://cs.chromium.org/chromium/src/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp?rcl=7d68ce72674bc9189bd8bcf305823d75c044489d&l=668
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f061caa204ec63d0aed8921101751c574915cafb

commit f061caa204ec63d0aed8921101751c574915cafb
Author: Daniel Cheng <dcheng@chromium.org>
Date: Mon Apr 10 20:57:03 2017

Rename FrameView::GetLayout() to FrameView::Layout().

I'm not actually sure why this was on the list of conflicting method
names, but it doesn't appear to be necessary.

Bug:  709987 
Change-Id: Ib2841a19243f485b9191dd933b92fdd3223470d2
Reviewed-on: https://chromium-review.googlesource.com/473367
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463389}
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/core/layout/LayoutPart.cpp
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/web/DevToolsEmulator.cpp
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
[modify] https://crrev.com/f061caa204ec63d0aed8921101751c574915cafb/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Comment 6 by f...@opera.com, Apr 10 2017 

FWIW, LayoutObject::GetLayout and LayoutBlock::GetLayoutBlock are related renames. (Both in the list referenced by c#4.)

Comment 7 by dcheng@chromium.org, Apr 10 2017 

Hmm... What would you suggest as an alternate name for layoutBlock(), since it conflicts with the class name?

Comment 8 by f...@opera.com, Apr 10 2017 

Yes... that's tricky. My best suggestion off the top of my head would be LayoutBlockContainer. (Don't think that collides with anything...)

Comment 9 by f...@opera.com, Apr 10 2017 

Or maybe LayoutContainingBlock...

Comment 10 by dcheng@chromium.org, Apr 10 2017

Cc: thakis@chromium.org dcheng@chromium.org
 Issue 710233  has been merged into this issue.

Comment 11 by dcheng@chromium.org, Apr 10 2017 

I'm preparing a CL to fix Layout*::GetLayout() -- but any suggestions on the best name for GetLayoutBlock() would be great. I'm leaning towards LayoutContainingBlock() myself, but I don't know much about layout.

Comment 12 by esprehn@chromium.org, Apr 10 2017 

Can we rename them all to Update*() since that's what they're actually doing? Document has updateLayout() too which is really the entry to all this stuff.

Comment 13 by dcheng@chromium.org, Apr 10 2017 

SGTM. I already renamed FrameView to Layout(), but I'll address it with the rest of the others.

Comment 14 by skobes@chromium.org, Apr 11 2017 

Please don't use LayoutContainingBlock - layoutBlock() lays out the current block, not the containing block.

LayoutThisBlock or UpdateBlockLayout would be fine.
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed375c02e956ef832e8ed6223435f0d78d6bdf77

commit ed375c02e956ef832e8ed6223435f0d78d6bdf77
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Apr 12 01:40:20 2017

Rename GetLayout()/GetLayoutBlock() to UpdateLayout()/UpdateBlockLayout()

The automated rename tool resolved these naming conflicts incorrectly.
This also changes FrameView::Layout() to FrameView::UpdateLayout() for
consistency.

BUG= 709987 
R=skobes@chromium.org
TBR=esprehn@chromium.org

Change-Id: Idaeacea9cdbe912c24c8388147a8a767c7baa5f2
Reviewed-on: https://chromium-review.googlesource.com/474547
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463884}
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutFlowThread.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutFrameSet.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutGrid.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutIFrame.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutIFrame.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutInline.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutListMarker.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutMedia.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutPagedFlowThread.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutPagedFlowThread.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutPart.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutPart.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutReplaced.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutRubyRun.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutSlider.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutSlider.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutSliderContainer.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTableRow.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTableSection.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutText.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutVTTCue.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutVideo.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutVideo.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/LayoutView.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/api/LayoutItem.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.h
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/web/DevToolsEmulator.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
[modify] https://crrev.com/ed375c02e956ef832e8ed6223435f0d78d6bdf77/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Comment 16 by dcheng@chromium.org, Apr 12 2017

Status: Fixed (was: Assigned)
Please re-open this if there's any other things that need to be cleaned up, but I think this should be all of them.
►

Sign in to add a comment