Issue metadata
Sign in to add a comment
|
24.3% regression in angle_perftests at 462844:462964 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 10 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982693500985366032
,
Apr 12 2017
=== Auto-CCing suspected CL author geofflang@chromium.org === Hi geofflang@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Geoff Lang Commit : 9aded17c25cfaae359b65dae3c015dc00a214aee Date : Wed Apr 05 20:14:13 2017 Subject: Invalidate completeness caches when enabling extensions. Bisect Details Configuration: winx64nvidia_perf_bisect Benchmark : angle_perftests Metric : Textures_d3d11_8_textures_5_rebind_3_state_8_mips/score Change : 23.69% | 1580.16666667 -> 1205.83333333 Revision Result N chromium@462843 1580.17 +- 27.1447 6 good chromium@462904 1602.83 +- 25.9005 6 good chromium@462908 1603.83 +- 33.6279 6 good chromium@462909 1610.0 +- 10.0 6 good chromium@462909,angle@f2209f74b3 1610.0 +- 5.09902 6 good chromium@462909,angle@60e17eab29 1594.33 +- 34.2247 6 good chromium@462909,angle@9aded17c25 1174.0 +- 83.4626 6 bad <-- chromium@462909,angle@72106562cd 1197.0 +- 31.8434 6 bad chromium@462910 1198.67 +- 5.22813 6 bad chromium@462912 1212.83 +- 7.79957 6 bad chromium@462919 1188.33 +- 47.4903 6 bad chromium@462934 1211.33 +- 20.7686 6 bad chromium@462964 1205.83 +- 24.7958 6 bad To Run This Test .\src\out\Release_x64\angle_perftests.exe --test-launcher-print-test-stdio=always --test-launcher-jobs=1 Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8982693500985366032 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5818830288322560 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 12 2017
PTAL Geoff, is it possible the completeness cache slowed down because of this change?
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/67f5ce42461d831cce30f737fa81919508c1368e commit 67f5ce42461d831cce30f737fa81919508c1368e Author: Geoff Lang <geofflang@chromium.org> Date: Wed Apr 12 17:52:07 2017 Fix the texture completeness cache. Two silly mistakes were landed in 9aded1: * The cache was not updating the sampler state it was using to compare against new ones. * The SamplerCompletenessCache entry was being copied and not updated. BUG= 709980 Change-Id: I1914ed30e24b9e48c4504da164f013a637a0b6c2 Reviewed-on: https://chromium-review.googlesource.com/475752 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/67f5ce42461d831cce30f737fa81919508c1368e/src/libANGLE/Texture.cpp [modify] https://crrev.com/67f5ce42461d831cce30f737fa81919508c1368e/src/libANGLE/Texture.h
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/67f5ce42461d831cce30f737fa81919508c1368e commit 67f5ce42461d831cce30f737fa81919508c1368e Author: Geoff Lang <geofflang@chromium.org> Date: Wed Apr 12 17:52:07 2017 Fix the texture completeness cache. Two silly mistakes were landed in 9aded1: * The cache was not updating the sampler state it was using to compare against new ones. * The SamplerCompletenessCache entry was being copied and not updated. BUG= 709980 Change-Id: I1914ed30e24b9e48c4504da164f013a637a0b6c2 Reviewed-on: https://chromium-review.googlesource.com/475752 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/67f5ce42461d831cce30f737fa81919508c1368e/src/libANGLE/Texture.cpp [modify] https://crrev.com/67f5ce42461d831cce30f737fa81919508c1368e/src/libANGLE/Texture.h
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41a618265465c164db0083511143b0bab5cdc697 commit 41a618265465c164db0083511143b0bab5cdc697 Author: geofflang <geofflang@chromium.org> Date: Wed Apr 12 21:59:25 2017 Roll ANGLE 20e005b..67f5ce4 https://chromium.googlesource.com/angle/angle.git/+log/20e005b..67f5ce4 BUG=602688, 709980 , 709232 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2816793002 Cr-Commit-Position: refs/heads/master@{#464164} [modify] https://crrev.com/41a618265465c164db0083511143b0bab5cdc697/DEPS
,
Apr 13 2017
Graph has recovered. Thanks for the fix Geoff! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jmad...@chromium.org
, Apr 10 2017