Make the overlflow menu for the new translate infobar |
|||||||
Issue descriptionMake the overlflow menu for the new translate compact infobar The overflow menu need to be: 1. popup from the bottom 2. covers infobar's close button when shows up. 3. has a divider line 4. options can be dynamically changed You can see what it's look like in this mock page: https://bbergher.googleplex.com/specs/translate/clank/static/ (scroll down to see the 'Overflow Menu')
,
Apr 10 2017
,
Apr 10 2017
You should also start linking to mocks so there's something for reviewers to compare against.
,
Apr 11 2017
,
Apr 11 2017
Sorry for the confusion. The menu is triggered when clicking on the "3 dots" button on the new infobar. I just added the mock links in the issue description.
,
Apr 11 2017
,
Apr 11 2017
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ce69f8079d73522380aa9c7ddb1847fdd940a99 commit 4ce69f8079d73522380aa9c7ddb1847fdd940a99 Author: martiw <martiw@chromium.org> Date: Thu Apr 13 09:06:37 2017 Make the Overflow Menu using ListPopupWindow for the new Translate infobar. BUG= 709964 Review-Url: https://codereview.chromium.org/2806273002 Cr-Commit-Position: refs/heads/master@{#464350} [add] https://crrev.com/4ce69f8079d73522380aa9c7ddb1847fdd940a99/chrome/android/java/res/layout/translate_menu_divider.xml [add] https://crrev.com/4ce69f8079d73522380aa9c7ddb1847fdd940a99/chrome/android/java/res/layout/translate_menu_item.xml [modify] https://crrev.com/4ce69f8079d73522380aa9c7ddb1847fdd940a99/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/4ce69f8079d73522380aa9c7ddb1847fdd940a99/chrome/android/java/res/values/dimens.xml [add] https://crrev.com/4ce69f8079d73522380aa9c7ddb1847fdd940a99/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java [modify] https://crrev.com/4ce69f8079d73522380aa9c7ddb1847fdd940a99/chrome/android/java_sources.gni
,
Apr 27 2017
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9146de1595631f543f2388239efba1ed1362704a commit 9146de1595631f543f2388239efba1ed1362704a Author: martiw <martiw@chromium.org> Date: Tue May 02 01:04:39 2017 Allow to use measured width in translate overflow menu When showing the overflow menu, we should use measured width (by setting fixedWidth to false) to make sure all items fit inside the menu. When showing the language menu (with 100+ languages), we should use the hardcoded width (fixedWidth = true) so that it won't take a long time to measure all item widths. BUG= 709964 Review-Url: https://codereview.chromium.org/2824083003 Cr-Commit-Position: refs/heads/master@{#468518} [add] https://crrev.com/9146de1595631f543f2388239efba1ed1362704a/chrome/android/java/res/layout/translate_menu_item_checked.xml [modify] https://crrev.com/9146de1595631f543f2388239efba1ed1362704a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java [modify] https://crrev.com/9146de1595631f543f2388239efba1ed1362704a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java [modify] https://crrev.com/9146de1595631f543f2388239efba1ed1362704a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
,
May 22 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dfalcant...@chromium.org
, Apr 10 2017