New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709954 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

webrtc and chromium results mixed in codesearch

Project Member Reported by jochen@chromium.org, Apr 10 2017

Issue description

if you go to e.g. cs.chromium.org/document.h sometimes the first hit is from the [webrtc] corpus.

for cs.chromium.org, it should only display results from chromium, as the webrtc stuff is mostly duplicates, but doesn't have cross refs or anything
 
 Issue 712468  has been merged into this issue.
 Issue 711835  has been merged into this issue.

Comment 3 by jochen@chromium.org, Apr 18 2017

Cc: dsansome@chromium.org
Labels: -Pri-3 Pri-1
can we maybe just deactivate webrtc while this is sorted out

Comment 4 by emso@chromium.org, Apr 18 2017

Sorry about this. Adding WebRTC as a separate package is the typical way of adding a new project to code search based on how things are designed. However, with chromium being the only package until now this means searching now requires filtering on the chromium package. 

Rolling back WebRTC to only staging again until we sort out how we want to handle this.

Comment 5 by emso@chromium.org, Apr 18 2017

We need to verify that the cleanup procedure is correct which means we will cleanup staging before prod. This takes a little while. Sorry for the inconvenience. 

Comment 6 by jochen@chromium.org, Apr 18 2017

maybe we can change cs.chromium.org to just include package:^chromium$ in the default query?

Comment 7 by emso@chromium.org, Apr 18 2017

That is one option. IT's added by default in some of the cases but not when you add a search without it in the search bar (except from the start page). We are rolling back to re-asses and then try again. Fully rolled back on staging as a test. I'll start the rollback on prod this afternoon CPH time.

Comment 8 by atotic@chromium.org, Apr 18 2017

Cc: atotic@chromium.org

Comment 9 by emso@chromium.org, Apr 18 2017

Status: Fixed (was: Untriaged)
WebRTC should be fully rolled back and there should not be any mixed results. Please re-open the bug if you still experience the issue. 

Sign in to add a comment