New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709938 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [MD History] Actions list are not seen properly on chrome://history page.

Reported by dchau...@etouch.net, Apr 10 2017 
Chrome Version: 59.0.3067.0 (Official Build) (64-bit) (cohort: Stable)e2ed4b4539b7a50d8be892e4437897b18c181c91-refs/heads/master@{#463157} 32/64-bit.
OS: Windows(7,8,10), Mac(10.11.6, 10.12.1, 10.12), Linux(14.04 LTS).

Precondition: Navigate to few webpages, such that history gets generated on chrome://history page.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://history page.
2. Keep focus on any 'Actions' icon using 'Tab' key and completely resize the browser from RHS to LHS.
3. Now, press 'Enter' key, slightly move the mouse pointer and observe the opened Actions list.

Actions list are misplaced and weird blank area are seen.
Actions list should not misplace.

This is a regression issue, broken in M-59 series, below is manual regression range.

Good build: 59.0.3064.0
Bad build: 59.0.3065.0

Kindly review the attached screen-cast for reference.
Actual screenshot.png
85.3 KB View Download
Actual behavior.mp4
1.2 MB View Download
Expected behavior.mp4
1.2 MB View Download

Comment 1 by dchau...@etouch.net, Apr 10 2017

Labels: hasbisect
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/e9d564bfe77be2833f5aa818ebc064f261692b06..897d20df0777854e91b4afab0923e917cd06640a?pretty=fuller&n=100

Suspecting: r462674

@scottchen: kindly help to reassign, if your changes are not related to this issue.

Comment 2 by scottchen@chromium.org, Apr 10 2017

Status: Started (was: Assigned)

Comment 3 by scottchen@chromium.org, Apr 10 2017 

Triaging result shows that the bug already existed prior to my CL - even if you completely use just keyboard you can reproduce the bug:
1. Launch chrome and navigate to chrome://history page.
2. Keep focus on any 'Actions' icon using 'Tab' key and completely resize the browser from RHS to LHS.
3. Now, press 'Enter' key, then up or down arrow.

It's just easier to notice now that we also allow mouse moves to focus things.

That said, I'll work on this and look for a fix.

Comment 4 by dpa...@chromium.org, Apr 10 2017

Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f416ef84abd82d7c45713fa69e8b44787251bf67

commit f416ef84abd82d7c45713fa69e8b44787251bf67
Author: scottchen <scottchen@chromium.org>
Date: Wed Apr 12 01:45:18 2017

WebUI: Fix cr-action-menu opening outside of layout.

BUG= 709938 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2810873002
Cr-Commit-Position: refs/heads/master@{#463887}

[modify] https://crrev.com/f416ef84abd82d7c45713fa69e8b44787251bf67/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

Comment 6 by dchau...@etouch.net, Apr 13 2017 

Re-tested this issue on Windows-7 machine using latest Canary chrome version 	59.0.3070.0 (Official Build). It's seems to be fixed and working as intended.

Attaching screen-cast for the same.
Latest Canary behavior.mp4
923 KB View Download

Comment 7 by scottchen@chromium.org, Apr 13 2017

Status: Fixed (was: Started)

Comment 8 by sandeepkumars@chromium.org, Apr 18 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3071.9
Tested the issue on Win 10, Mac 10.12.4 , Ubuntu 14.04 using 59.0.3071.9 and now the issue is working as expected.
►

Sign in to add a comment