New issue
Advanced search Search tips

Issue 709934 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

gn needs to escape curly brackets to avoid brace expansion in bash

Project Member Reported by ol...@opera.com, Apr 10 2017

Issue description

Chrome Version: current
OS: linux

What steps will reproduce the problem?

Call python with a parameter containing the string "{a,b}{c,d}" on a linux distro using bash as shell.

What is the expected result?

The curly brackets should be escaped to avoid brace expansion in bash.

What happens instead?

The string is expanded to "ac ad bc bd".

 

Comment 1 by ol...@opera.com, Apr 10 2017

Owner: ol...@opera.com
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fd3f6718896969f1a5d3850a6d81f4ccf74abd3

commit 7fd3f6718896969f1a5d3850a6d81f4ccf74abd3
Author: ollel <ollel@opera.com>
Date: Fri Apr 21 07:46:32 2017

Add curly brackets to list of characters that gn needs to escape

Curly brackets {} needs to be escaped to avoid brace expansion
on systems using bash as the default shell.

BUG= 709934 

Review-Url: https://codereview.chromium.org/2809633002
Cr-Commit-Position: refs/heads/master@{#466286}

[modify] https://crrev.com/7fd3f6718896969f1a5d3850a6d81f4ccf74abd3/tools/gn/escape.cc
[modify] https://crrev.com/7fd3f6718896969f1a5d3850a6d81f4ccf74abd3/tools/gn/escape_unittest.cc

Comment 3 by ol...@opera.com, Apr 21 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment