New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709933 link

Starred by 1 user
Status: Duplicate
Merged: issue 703894
Owner: ----
Closed: Apr 2017
Cc:
jochen@chromium.org
█ tansell@chromium.org
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CQ should run `webkit_tests` more often.

Project Member Reported by mkwst@chromium.org, Apr 10 2017 
This morning, I reverted both https://codereview.chromium.org/2803303002/ and https://codereview.chromium.org/2786013002/ because they broke layout tests.

Since those patches only changed code outside of `//third_party/WebKit`, it seems that we skipped `webkit_tests` entirely. That's unfortunate. Perhaps we can stop skipping those tests, since `//content`/`DEPS` and `//third_party/WebKit` are fairly inextricably intertwined?

Comment 1 by jochen@chromium.org, Apr 10 2017

Cc: dpranke@chromium.org tansell@chromium.org
Maybe we should use the "real" analyze to figure out that layout tests should be run, instead of using the check for changes to third_party/WebKit?

The more we move to //blink, the more dangerous the lack of doing so will become

Comment 2 by tandrii@chromium.org, Apr 10 2017

Components: -Infra>CQ Infra>Client>Chrome
Removing from Infra>CQ for Blink>Infra to look and act on it.

Comment 3 by tansell@chromium.org, Apr 10 2017 

Already have plans to do this. See https://bugs.chromium.org/p/chromium/issues/detail?id=703894

Comment 4 by dpranke@chromium.org, Apr 10 2017

Mergedinto: 703894
Status: Duplicate (was: Untriaged)

Comment 5 by tansell@chromium.org, Apr 10 2017 

Just to be clear, we very much want this to happen and have been working on this effort for a while now!
►

Sign in to add a comment