Issue metadata
Sign in to add a comment
|
MD Settings / OOBE: Update image for unknown users |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3065.0/9448.0.0 dev-channel Daisy,Minnie and Candy OS: Chrome What steps will reproduce the problem? (1)Sign in to user -> Go to chrome://md-settings (2)Now at 'People' section select 'Manage other people' option which navigates to 'Manage Other users' page -> Enable 'Restrict sign-in to the following users' option so that 'Add person' option is enabled (3)Now click on 'Add person' -> Enter any email id -> Now observe User name (Please refer Video and screenshot) Expected: User Name should be proper for added persons i.e. created 'msatlinux' and 'Etwindowsbisect' persons so only Names should be seen as User Name and then Gmail Id should be seen Actual: Instead Gmail Id is seen as User Name i.e. 'msatlinux@gmail.com' and 'Etwindowsbisect@gmail.com'(Gmail ids are msatlinux@gmail.com and Etwindowsbisect@gmail.com)are seen as User Names This is Regression Issue as same is working fine in chrome://settings @stevenjb : Please confirm the Issue Note : Parent Profile user name is proper but the Issue is with created persons in 'Manage other Users' page
,
Apr 11 2017
Im more concerned with using the proper avatars. We should be able to retrieve the proper GAIA/Chrome avatar without needing to use the "beaker" image. If a fallback is necessary, please use the generic grey avatar image. https://icons.googleplex.com/#icon=logo_avatar_anonymous&search=avatar
,
Apr 11 2017
The beaker is generated at a lower level, see: chrome://userimage/nobody@gmail.com Alan, if you want to replace that image (we appear to use it in OOBE as well), could you open a separate issue for that? Also, it sounds like you are OK with the duplicated email address here?
,
Apr 13 2017
Re purposing this issue. For clarification: This issue affects users added to the 'Restrict sign-in to the following users' section. For users that have never logged in, Chrome OS does not know their user name or their profile picture. There are two things I think we should do here: 1. Duplicating the email address is a bit silly, we should just show it once when we do not know the user name. 2. We should update the image as suggested in comment #2. Tom / Alan, please comment if you have corrections or additional suggestions A mock here would also be nice :)
,
Apr 19 2017
+zalcorn for OOBE Re #1 -- agreed we should only show the email address once Re #2 -- I'm supportive of updating the avatar everywhere, though we'll need to confirm that OOBE folks are okay with it as well
,
Apr 19 2017
,
Apr 19 2017
SGTM. Elizabeth, are you okay with the grey anonymous user icon?
,
Apr 26 2017
I will address the duplicate email in issue 715518 .
,
Apr 26 2017
Renaming / re-purposing this for the image change. Elizabeth: Still waiting on an OK to switch to the grey anonymous user icon for OOBE.
,
Apr 26 2017
stevenjb@ Would you mind to send me the screenshot of the grey anonymous user icon?
,
Apr 26 2017
Alan provided a link above, but here it is again: https://icons.googleplex.com/#icon=logo_avatar_anonymous&search=avatar
,
Apr 26 2017
Thanks Steven. Let's use this icon.
,
May 18 2017
,
May 25 2017
,
Jun 26 2017
,
Jun 26 2017
,
Jul 19 2017
,
Jul 19 2017
Attached: Updated image in avatar picker and 'Manage other people' UI.
,
Jul 19 2017
Looks good!
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48cdce0b716141ef19df5080b707c3dd1f3975f9 commit 48cdce0b716141ef19df5080b707c3dd1f3975f9 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Jul 21 23:45:19 2017 CrOS: Update default avatar for MD This eliminates the inconsistent 'beaker' image and replaces it with a new image. It also merges the 'loading' image with the default image. Bug: 709917 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I139d8555c2beb7417d1e79b128ae5ca680258084 Reviewed-on: https://chromium-review.googlesource.com/578556 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#488806} [delete] https://crrev.com/b282477655a78d97a5e25f89c4612e3dfa61115a/chrome/app/theme/default_100_percent/profile_loading.png [delete] https://crrev.com/b282477655a78d97a5e25f89c4612e3dfa61115a/chrome/app/theme/default_200_percent/profile_loading.png [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/chrome/browser/resources/chromeos/user_images_grid.js [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/chrome/browser/ui/ash/session_controller_client.cc [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/chrome/browser/ui/webui/options/chromeos/user_image_source.cc [add] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/ui/chromeos/resources/default_100_percent/default_user_images/avatar_anonymous.png [delete] https://crrev.com/b282477655a78d97a5e25f89c4612e3dfa61115a/ui/chromeos/resources/default_100_percent/default_user_images/avatar_beaker.png [add] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/ui/chromeos/resources/default_200_percent/default_user_images/avatar_anonymous.png [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/ui/chromeos/resources/ui_chromeos_resources.grd [modify] https://crrev.com/48cdce0b716141ef19df5080b707c3dd1f3975f9/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Jul 24 2017
,
Aug 3 2017
Verified on M62 (Chrome OS 9801.0.0, 62.0.3174.0 dev build).
,
Aug 3 2017
Hey folks, one thing we didn't account for is how this looks in the shelf, which is not great (because it's a circle, instead of a square). We should probably be using avatar anonymous square here: https://icons.googleplex.com/#icon=logo_avatar_anonymous_square&search=avatar
,
Aug 3 2017
It will take some development effort to use a different icon there. It shouldn't be too tricky, but we should file a separate issue for that if it's a concern.
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34188d39ecbe5b57bc9865114309b47759c16776 commit 34188d39ecbe5b57bc9865114309b47759c16776 Author: David Reveman <reveman@chromium.org> Date: Sat Aug 12 04:39:29 2017 CrOS: Update default avatar for MD This eliminates the inconsistent 'beaker' image and replaces it with a new image. It also merges the 'loading' image with the default image. TBR=stevenjb@chromium.org (cherry picked from commit 48cdce0b716141ef19df5080b707c3dd1f3975f9) Bug: 709917 , 721647 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I139d8555c2beb7417d1e79b128ae5ca680258084 Reviewed-on: https://chromium-review.googlesource.com/578556 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488806} Reviewed-on: https://chromium-review.googlesource.com/611677 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#500} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [delete] https://crrev.com/7b7b48e888ace0b606bde71a83814a41d28a962a/chrome/app/theme/default_100_percent/profile_loading.png [delete] https://crrev.com/7b7b48e888ace0b606bde71a83814a41d28a962a/chrome/app/theme/default_200_percent/profile_loading.png [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/chrome/browser/resources/chromeos/user_images_grid.js [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/chrome/browser/ui/ash/session_controller_client.cc [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/chrome/browser/ui/webui/options/chromeos/user_image_source.cc [add] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/ui/chromeos/resources/default_100_percent/default_user_images/avatar_anonymous.png [delete] https://crrev.com/7b7b48e888ace0b606bde71a83814a41d28a962a/ui/chromeos/resources/default_100_percent/default_user_images/avatar_beaker.png [add] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/ui/chromeos/resources/default_200_percent/default_user_images/avatar_anonymous.png [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/ui/chromeos/resources/ui_chromeos_resources.grd [modify] https://crrev.com/34188d39ecbe5b57bc9865114309b47759c16776/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Apr 10 2017Labels: -Pri-1 Pri-3
Owner: bettes@chromium.org