New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709915 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Animation is not smooth while opening 'Report an issue' overlay.

Reported by rp...@etouch.net, Apr 10 2017

Issue description

Version: 59.0.3067.0 e2ed4b4539b7a50d8be892e4437897b18c181c91-refs/heads/master@{#463157}
OS: Windows 7

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/help 
2. Now click on 'Report an issue' and after clicking on it observe the animation while opening 'Report an issue' overlay

Actual: Animation is not smooth while opening 'Report an issue' overlay
Expected: Animation should be smooth while opening 'Report an issue' overlay

This is regression issue, broken in ‘M 59’ and will soon update other info :
Good build:59.0.3065.0
Bad build: 59.0.3066.0

Note : Issue is not seen in Windows(8,10),Linux and Mac OS.
 
Actual_video.mp4
758 KB View Download
Expected_video.mp4
424 KB View Download
Cc: sureshkumari@chromium.org
Labels: hasbisect-per-revision
Owner: guidou@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3065.0 (Revision:462712).
Bad build: 59.0.3066.0 (Revision:463122).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/311b4ebadca3e47753627f385ee4ce3482331404..258527ddc93825a5feac1bd3de5f5efb8d975856

Review-Url: https://codereview.chromium.org/2806703002

@guidou: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.

Comment 2 by guidou@chromium.org, Apr 10 2017

I'm looking into the issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71ffa0d2e073d09d8098b0794f7f382655aabedc

commit 71ffa0d2e073d09d8098b0794f7f382655aabedc
Author: guidou <guidou@chromium.org>
Date: Mon Apr 10 17:26:49 2017

Update selection of resolution policy for screen capture with getUserMedia.

The intent of the new algorithm is to allow resolution adjustment if the
resolution range allowed by constraints is a superset of the capabilities.
However, the actual capabilities are not currently known and, in practice,
resolution adjustment was allowed only when no constraints were specified.

This CL relaxes this rule to allow resolution adjustment by treating a max
constraint as if it were the actual capability. This should be updated so
that the actual native screen resolution is used as capability, but, in the
meantime, this fix is more compatible with existing applications that expect
the behavior of the old algorithm. Moreover, this patch does not affect spec
compliance since screen-resolution policies are not regulated by the spec as
long as the output resolution is within the constrained range.

BUG= 709915 

Review-Url: https://codereview.chromium.org/2800343005
Cr-Commit-Position: refs/heads/master@{#463309}

[modify] https://crrev.com/71ffa0d2e073d09d8098b0794f7f382655aabedc/content/renderer/media/media_stream_constraints_util_video_content.cc
[modify] https://crrev.com/71ffa0d2e073d09d8098b0794f7f382655aabedc/content/renderer/media/media_stream_constraints_util_video_content_unittest.cc

Comment 4 by guidou@chromium.org, Apr 11 2017

Status: Fixed (was: Assigned)

Comment 5 by guidou@chromium.org, Apr 11 2017

This is fixed in r463309.
When verifying, please don't compare with 59.0.3065.0, but with 59.0.3064.0 or older.
There is a bug in 59.0.3065.0 that makes it capture at 640x480 in most cases, which produces a smaller image than usual, which makes it faster. Thus, this is not the right baseline.
59.0.3066.0 on the other hand was capturing at a larger resolution than usual, which made it slightly slower.
The fix restores capture resolution to what it was in 3064 and before.

Labels: TE-Verified-59.0.3071.9 TE-Verified-M59
Tested the issue on Win 7 Using 59.0.3071.9 and the animation is smooth now on opening Report an issue Overlay.

Please find the attached screen cast
709915.mp4
463 KB View Download

Sign in to add a comment